Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing 3d transform in refresh controller #6016

Closed
RaederDev opened this issue Apr 1, 2016 · 1 comment
Closed

Missing 3d transform in refresh controller #6016

RaederDev opened this issue Apr 1, 2016 · 1 comment

Comments

@RaederDev
Copy link

Short description of the problem:

This is more a question than a problem since I've already solved it but here it goes:
refresherController.js uses translateY for the overscroll effect resulting in really bad performance on Android devices (and probably also on iOS).

I replaced

scrollChild.style[ionic.CSS.TRANSFORM] = 'translateY(' + val + 'px)';

with

scrollChild.style[ionic.CSS.TRANSFORM] = 'translate3d(0,' + val + 'px,0)';

resulting in a noticeable performance boost since the animation is now 3D accelerated by the GPU.

My question is if there is a specific reason why you don't use a 3d translate here (compatibility etc.) or can I open a pull request and replace this for everybody?

Which Ionic Version? 1.x or 2.x
1.x

Run ionic info from terminal/cmd prompt: (paste output below)
Your system information:

Cordova CLI: 6.1.0 (cordova-lib@undefined)
Gulp version: CLI version 1.2.1
Gulp local: Local version 3.9.1
Ionic CLI Version: 1.7.14
Ionic App Lib Version: 0.7.0
OS: /bin/sh: lsb_release: command not found
Node Version: v5.10.0

@danbucholtz
Copy link
Contributor

Hi @N0ps32,

Thanks for letting us know about this. I am going to close this issue and work off of the PR going forward. I think we can get this merged in as long as it works with iOS 7 and above. I need to verify that.

Thanks for contributing to Ionic!

Thanks,
Dan

danbucholtz added a commit that referenced this issue May 9, 2016
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants