Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support angular 17 #503

Merged
merged 7 commits into from
Nov 30, 2023
Merged

feat: support angular 17 #503

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
097fb2a
feat(cordova-builders): ng17
liamdebeasi Nov 29, 2023
13c15ae
fix: do not error on console log build
liamdebeasi Nov 29, 2023
e8a9387
feat(schematics): support ng17
liamdebeasi Nov 29, 2023
b25ba38
update ts
liamdebeasi Nov 29, 2023
6afd058
update ts again
liamdebeasi Nov 29, 2023
d2148c9
forgot to add package lock
liamdebeasi Nov 29, 2023
01176d6
update
liamdebeasi Nov 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions packages/cordova-builders/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,11 @@
"ionicframework"
],
"dependencies": {
"@angular-devkit/architect": "^0.1600.0",
"@angular-devkit/build-angular": "^16.0.0",
"@angular-devkit/core": "^16.0.0",
"@angular-devkit/schematics": "^16.0.0",
"@schematics/angular": "^16.0.0",
"@angular-devkit/architect": "^0.1700.0",
"@angular-devkit/build-angular": "^17.0.0",
"@angular-devkit/core": "^17.0.0",
"@angular-devkit/schematics": "^17.0.0",
"@schematics/angular": "^17.0.0",
"cheerio": "^1.0.0-rc.10",
"colorette": "^2.0.16",
"copy-webpack-plugin": "^9.0.1",
Expand All @@ -50,7 +50,7 @@
"@types/node": "^16.11.7",
"@types/ws": "^8.2.0",
"lint-staged": "^12.0.2",
"typescript": "~5.0.2"
"typescript": "~5.2.0"
},
"builders": "./builders.json",
"schematics": "./collection.json",
Expand Down
6 changes: 3 additions & 3 deletions packages/schematics/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,9 @@
"ionicframework"
],
"dependencies": {
"@angular-devkit/core": "^16.0.0",
"@angular-devkit/schematics": "^16.0.0",
"@schematics/angular": "^16.0.0"
"@angular-devkit/core": "^17.0.0",
"@angular-devkit/schematics": "^17.0.0",
"@schematics/angular": "^17.0.0"
},
"devDependencies": {
"lint-staged": "^12.0.2",
Expand Down
2 changes: 1 addition & 1 deletion tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"skipLibCheck": true,
"strict": true,
"target": "es2018",
"lib": ["es2018"],
"lib": ["es2018", "dom"],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this, I get the following error on build:

util/ast-util.ts:374:5 - error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.

374     console.error('No app module found. Please add your new class to your component.');
        ~~~~~~~

"plugins": [{ "name": "typescript-eslint-language-service" }]
},
"include": ["**/*.ts"],
Expand Down