feat: support angular 17 #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamdebeasi
commented
Nov 29, 2023
| @@ -13,7 +13,7 @@ | |||
| "skipLibCheck": true, | |||
| "strict": true, | |||
| "target": "es2018", | |||
| "lib": ["es2018"], | |||
| "lib": ["es2018", "dom"], | |||
There was a problem hiding this comment.
Without this, I get the following error on build:
util/ast-util.ts:374:5 - error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
374 console.error('No app module found. Please add your new class to your component.');
~~~~~~~
sean-perkins
approved these changes
Nov 30, 2023
liamdebeasi
added a commit
that referenced
this pull request
Jan 9, 2024
This reverts commit 26f0cd9.
liamdebeasi
added a commit
that referenced
this pull request
Jan 9, 2024
This reverts commit feb6361.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates dependencies to support version 17 of Angular
BREAKING CHANGE: The minimum version of Angular required is now 17. Please updates your apps to use
the latest release of Angular.
resolves #502