Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't warn on unload in iframe #2884

Merged
merged 1 commit into from
May 28, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# (Unreleased; add upcoming change notes here)

- Fix one last case where the user might be warned unnecessarily when navigating
away from iodide (#2884)

# 0.20 (2020-05-23)

- Allow creating iodide notebook with attached files via a POST request, using
Expand Down
2 changes: 0 additions & 2 deletions src/eval-frame/index.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import messagePasserEval from "../shared/utils/redux-to-port-message-passer";
import { iodide } from "./iodide-api/api";

import "./port-to-editor";
import { handleInterceptBackspace } from "../shared/intercept-keybindings";

messagePasserEval.connectDispatch(store.dispatch);
window.iodide = iodide;
Expand All @@ -43,6 +42,5 @@ render(
document.getElementById("view-mode-styles")
);

handleInterceptBackspace();
// initializeUserVariables() **MUST** be the last line of this file!
initializeUserVariables();
21 changes: 0 additions & 21 deletions src/shared/intercept-keybindings.js

This file was deleted.