Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't warn on unload in iframe #2884

Merged
merged 1 commit into from
May 28, 2020

Conversation

wlach
Copy link
Contributor

@wlach wlach commented May 28, 2020

The parent frame takes care of warning in case of navigation events,
so this is unnecessary (it was also set to fire basically
unconditionally which meant that people were being warned unnecessarily
if e.g. in the report view)

No tests because there is no need to test something we're no longer doing. :)

Pull Request checklist

  • [N/A] Documentation: If this feature has or requires documentation, the relevant docs have been updated.
  • Changelog: This PR updates the changelog with any user-visible changes.
  • [N/A] Tests: This PR includes thorough tests or an explanation of why it does not

@codecov
Copy link

codecov bot commented May 28, 2020

Codecov Report

Merging #2884 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2884   +/-   ##
=======================================
  Coverage   72.53%   72.53%           
=======================================
  Files         247      247           
  Lines        6102     6102           
  Branches      994      994           
=======================================
  Hits         4426     4426           
  Misses       1657     1657           
  Partials       19       19           

The parent frame takes care of warning in case of navigation events,
so this is unnecessary (it was also set to fire basically
unconditionally which meant that people were being warned unnecessarily
if e.g. in the report view)
@wlach wlach force-pushed the dont-warn-on-unload-in-iframe branch from 5f306a7 to db7bac8 Compare May 28, 2020 13:28
@wlach wlach merged commit b720102 into iodide-project:master May 28, 2020
@wlach wlach deleted the dont-warn-on-unload-in-iframe branch May 28, 2020 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant