feat(nodes): versioning #4449
Merged
feat(nodes): versioning #4449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
requested review from
blessedcoolant,
maryhipp,
lstein,
Kyle0654,
brandonrising,
hipsterusername and
Millu
as code owners
The `@invocation` decorator is extended with an optional `version` arg. On execution of the decorator, the version string is parsed using the `semver` package (this was an indirect dependency and has been added to `pyproject.toml`). All built-in nodes are set with `version="1.0.0"`. The version is added to the OpenAPI Schema for consumption by the client.
- Node versions are now added to node templates - Node data (including in workflows) include the version of the node - On loading a workflow, we check to see if the node and template versions match exactly. If not, a warning is logged to console. - The node info icon (top-right corner of node, which you may click to open the notes editor) now shows the version and mentions any issues. - Some workflow validation logic has been shifted around and is now executed in a redux listener.
psychedelicious
force-pushed
the
feat/nodes/versioning
branch
from
0b9183b to
3dbb0e1
Compare
blessedcoolant
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Have you discussed this change with the InvokeAI team?
Have you updated all relevant documentation?
Description
This PR is based on #4423 and should not be merged until it is merged.
feat(nodes): add version to node schemas
The
@invocationdecorator is extended with an optionalversionarg. On execution of the decorator, the version string is parsed using thesemverpackage (this was an indirect dependency and has been added topyproject.toml).All built-in nodes are set with
version="1.0.0".The version is added to the OpenAPI Schema for consumption by the client.
feat(ui): handle node versions
Related Tickets & Documents
QA Instructions, Screenshots, Recordings
Loading old workflows should prompt a warning, and the node status icon should indicate some action is needed.
[optional] Are there any post deployment tasks we need to perform?
I've updated the default workflows:
Default Workflows.zip
I'm not sure where these are being stored right now @Millu