-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(auth): Add Expo support for phone auth #6645
feat(auth): Add Expo support for phone auth #6645
Conversation
Co-authored-by: Bartłomiej Klocek <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Codecov Report
@@ Coverage Diff @@
## main #6645 +/- ##
==========================================
+ Coverage 72.20% 72.33% +0.14%
==========================================
Files 115 116 +1
Lines 4754 4792 +38
Branches 1064 1072 +8
==========================================
+ Hits 3432 3466 +34
- Misses 1240 1244 +4
Partials 82 82 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just bumped the config plugin dep to v5 (along with a trivial forward port for the same) to match deps from #6482 and force pushed it to get CI through - should be good to go from that
Thanks for rescuing the PR and getting it through
Great to see that you took care of this feature! 😀 After a brief look it looks good to me, glad you added unit tests 😉 |
@barthap I always appreciate the support on the Expo stuff - highly valued - thanks! |
Almost unbelievably we still have a transitive dependency on the deprecated jcenter repository and they must be doing an unscheduled brownout (to surface these deps...) which failed the android build
I just fixed it I think with https://github.com/invertase/jet/releases/tag/v0.8.2 but it is not worth pushing in this PR to fix CI because the PR is ios + javascript only and those checks passed. |
Description
I rebased #6167 on main after #6472 stalled.
I also added a missing info plist value check and removed a duplicated app.json config key existance check.
Also added some tests for the config plugin. Let's see whether this makes CI happy :)
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Compared plugin with official setup instructions for iOS and confirmed that Android doesn't need any extra steps.
Also added some tests to verify the plugin does what it's supposed to do.
🔥 :)
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter