-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(auth): Add Expo support for phone auth #6167 #6472
Conversation
Co-authored-by: Bartłomiej Klocek <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Prashanth kumar Duggishetti seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
@nandorojo thanks for the original PR |
Hey @pduggi-cf this seems great! Thanks for picking it up and pushing it forward, I appreciate it. It looks like this is just missing the CLA signed by you - can you do that by following either the Details link in the failing check on it or in the comment above? Thanks! |
Codecov Report
@@ Coverage Diff @@
## main #6472 +/- ##
============================================
- Coverage 54.90% 54.17% -0.73%
+ Complexity 689 680 -9
============================================
Files 208 208
Lines 10358 10358
Branches 1645 1645
============================================
- Hits 5686 5610 -76
- Misses 4371 4463 +92
+ Partials 301 285 -16 |
I have signed it a while ago not sure why it says my CLA signature is still pending |
In my experience that is usually because the CLA was somehow signed with a different user (keyed by email address) than was expected here. Perhaps you are missing an email alias in your github account or something similar? |
It looks like to two commits Dev dependies to yarn and yarn.lock are not associated with your email address. I would try to set up your email address in git and then recommit those two commits and force push. |
Hey @pduggi-cf! Just wondering if you're planning on trying to fix the CLA here again. I'd love to get this merged and use it in a Solito example app. Thanks again for picking it up. |
@nandorojo sorry, for some reason I thought this was already merged, I'll get to it later today. Thanks for bringing it back |
There is a conflict now and the CLA is still not signed, but I did add hacktoberfeft-accepted tag in case someone wants that ;-) |
Running around due to a medical emergency, might take a while
…On Fri, Oct 21, 2022, 6:04 PM Mike Hardy ***@***.***> wrote:
There is a conflict now and the CLA is still not signed, but I did add
hacktoberfeft-accepted tag in case someone wants that ;-)
—
Reply to this email directly, view it on GitHub
<#6472 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASE4WKC73EH2W4QN2KBBKODWEKEU3ANCNFSM56UVRMOA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Superceded by #6645 |
Add @react-native-firebase/auth config plugin, which enables captcha for phone auth by modifying Info.Plist.
The config plugin is automating the reCAPTCHA verification steps from the firebase iOS docs.
Add docs to the Phone Auth page for Expo users.
Sorry for some reason the checklist didn't show up here when I created the PR. I'll try to find it.
Related: #5936
Updating PR #6167