Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): Add Expo support for phone auth #6167 #6472

Closed
wants to merge 11 commits into from

Conversation

pduggi-cf
Copy link

@pduggi-cf pduggi-cf commented Aug 16, 2022

Add @react-native-firebase/auth config plugin, which enables captcha for phone auth by modifying Info.Plist.
The config plugin is automating the reCAPTCHA verification steps from the firebase iOS docs.
Add docs to the Phone Auth page for Expo users.

Sorry for some reason the checklist didn't show up here when I created the PR. I'll try to find it.

Related: #5936

Updating PR #6167

@vercel
Copy link

vercel bot commented Aug 16, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-native-firebase ✅ Ready (Inspect) Visit Preview Aug 16, 2022 at 7:24AM (UTC)
1 Ignored Deployment
Name Status Preview Updated
react-native-firebase-next ⬜️ Ignored (Inspect) Aug 16, 2022 at 7:24AM (UTC)

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ nandorojo
❌ Prashanth kumar Duggishetti


Prashanth kumar Duggishetti seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@pduggi-cf
Copy link
Author

@nandorojo thanks for the original PR

@mikehardy
Copy link
Collaborator

Hey @pduggi-cf this seems great! Thanks for picking it up and pushing it forward, I appreciate it.
I also appreciate your patience, I was traveling and I am just now getting caught back up so I can process PRs again.

It looks like this is just missing the CLA signed by you - can you do that by following either the Details link in the failing check on it or in the comment above? Thanks!

@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #6472 (7895d43) into main (dc74643) will decrease coverage by 0.74%.
The diff coverage is n/a.

❗ Current head 7895d43 differs from pull request most recent head 92c24a6. Consider uploading reports for the commit 92c24a6 to get more accurate results

@@             Coverage Diff              @@
##               main    #6472      +/-   ##
============================================
- Coverage     54.90%   54.17%   -0.73%     
+ Complexity      689      680       -9     
============================================
  Files           208      208              
  Lines         10358    10358              
  Branches       1645     1645              
============================================
- Hits           5686     5610      -76     
- Misses         4371     4463      +92     
+ Partials        301      285      -16     

@pduggi-cf
Copy link
Author

@mikehardy
image

I have signed it a while ago not sure why it says my CLA signature is still pending

@mikehardy
Copy link
Collaborator

x Prashanth kumar Duggishetti

In my experience that is usually because the CLA was somehow signed with a different user (keyed by email address) than was expected here. Perhaps you are missing an email alias in your github account or something similar?

@pduggi-cf
Copy link
Author

pduggi-cf commented Aug 28, 2022

image

image

I am not sure what to do now... i also used github to signing in fyi

@DoctorJohn
Copy link
Contributor

It looks like to two commits Dev dependies to yarn and yarn.lock are not associated with your email address. I would try to set up your email address in git and then recommit those two commits and force push.

@nandorojo
Copy link
Contributor

Hey @pduggi-cf! Just wondering if you're planning on trying to fix the CLA here again. I'd love to get this merged and use it in a Solito example app. Thanks again for picking it up.

@pduggi-cf
Copy link
Author

@nandorojo sorry, for some reason I thought this was already merged, I'll get to it later today. Thanks for bringing it back

@mikehardy mikehardy added the hacktoberfest-accepted Let's plant some trees! label Oct 21, 2022
@mikehardy
Copy link
Collaborator

There is a conflict now and the CLA is still not signed, but I did add hacktoberfeft-accepted tag in case someone wants that ;-)

@pduggi-cf
Copy link
Author

pduggi-cf commented Oct 21, 2022 via email

@mikehardy
Copy link
Collaborator

Superceded by #6645

@mikehardy mikehardy closed this Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants