Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX][Compile][Android] - backwards-compatible AndroidX dependency #2476

Merged
merged 1 commit into from
Sep 19, 2019

Conversation

mikehardy
Copy link
Collaborator

I needed this in my project to successfully use this with modern (divergent) numbers for the support libraries - core is at 1.0.2 but support-v4 is at 1.0.0 and media is at 1.0.1 etc.

use 'supportV4Version' in your ext{} block in build.gradle to use it

Assuming this passes CI and is good to go, I'll update the docs repo for changelogs for a 5.5.7 release etc (and I'm traveling back from vacation right now, I could work to shape up a 5.5.7 release and release it if that helps)

This was supposed to be in #2445 but I didn't make a feature branch and clobbered the change 🤦‍♂ I am using this locally in production though

Summary

Checklist

  • Supports Android
  • Supports iOS
  • e2e tests added or updated in /tests/e2e/*
  • Updated the documentation in the docs repo
    • LINK TO DOCS PR HERE
  • Flow types updated
  • Typescript types updated

Test Plan

Release Plan

[CATEGORY][type] [LOCATION] - Message


Think react-native-firebase is great? Please consider supporting the project with any of the below:

use 'supportV4Version' in your ext{} block in build.gradle to use it
@codecov
Copy link

codecov bot commented Aug 11, 2019

Codecov Report

Merging #2476 into v5.x.x will increase coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           v5.x.x    #2476      +/-   ##
==========================================
+ Coverage   75.89%   76.02%   +0.13%     
==========================================
  Files          61       61              
  Lines        1576     1576              
==========================================
+ Hits         1196     1198       +2     
+ Misses        380      378       -2

@mikehardy mikehardy mentioned this pull request Aug 11, 2019
@mikehardy
Copy link
Collaborator Author

This is the change I would release as 5.5.7 but it's failing on the android emulator, and I would have the android emulator on it's own port etc except I need help on upgrading the tests project to RN60 #2473 :-), I'm trying though haha

@mikehardy mikehardy requested a review from Salakar August 11, 2019 18:08
@mikehardy
Copy link
Collaborator Author

I just can't get the android step to complete :-(

[18:03:24] [Step 5/7] detox[71586] ERROR: [exec.js/EXEC_FAIL, #13] "/usr/local/share/android-sdk/platform-tools/adb -s emulator-5554 shell "ps | grep \"com\.invertase\.testing$\""" failed with code = 1, stdout and stderr:

nothing else in the logs

This is needed for RN60 people on v5.5.x though, depending on their library mix

@mikehardy
Copy link
Collaborator Author

This is blocking people in other projects I think. Here's the patch file for use with patch-package (just remove the '.txt' suffix, it is needed for github to attach it)

react-native-firebase+5.5.6.patch.txt

@Salakar Salakar merged commit 8177f9d into invertase:v5.x.x Sep 19, 2019
@mikehardy mikehardy deleted the androidx-deps branch August 14, 2020 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants