AndroidX support

[OleksandrKucherenko]

[Edited: Note for people that want to use AndroidX - it is possible]

🔽 please see the comment below 🔽

#1588 (comment)

[Salakar]

@OleksandrKucherenko it is something that I'd like to switch over to eventually yes, I've quickly gone through the project and checked what we use it for overall, the majority of it was NonNull/Nullable annotations - I've just switched all these over to use javax.annotation.Nonnull/Nullable; (here) and after that all that remains is the following:

The 2x RequiresPermission ones will be obselete in v6 as these will move into the packages AndroidManifest files.

All that remains then is the usage in Notifications & Messaging, if you'd like to send a PR for this that'd be super handy - it might not get a direct merge but it would definitely form the basis of swapping it out for v6.0.0.

If you could come on our discord chat I'd be up for chatting about it and if there's anything else Android side that you think needs doing 👍

---

Loving react-native-firebase and the support we provide? Please consider supporting us with any of the below:

• 👉 Back financially via Open Collective
• 👉 Follow React Native Firebase and Invertase on Twitter
• 👉 Star this repo on GitHub ⭐️

[sinewave440hz]

Hi. Would just like to note that I have just tried to upgrade to AndroidX as an attempt to solve some support library dependency issues in other packages. Unfortunately the only thing blocking me now is react-native-firebase - (android.support.annotation does not exist). Are there any plans to make the changes at this stage? Thanks!

[OleksandrKucherenko]

@sinewave440hz you can use old android.support.annotations library. Its just an annotation classes that are not used in runtime, they only used for Android Studio IDE (Intellij) for validating parameters of methods, call sequence, multi-threading requirements, etc. Including of OLD (not androidx support library with annotations will not make any harm).

[sinewave440hz]

I see. Given that I've otherwise successfully built my app using AndroidX, could you suggest more specifically how I can get my app to build? I have 20 errors that are related to this that I'm not sure how to fix:

error: package android.support.annotation does not exist
error: package android.support.v4.content does not exist
error: cannot find symbol variable LocalBroadcastManager
error: cannot find symbol class RemoteInput
error: package android.support.v4.content does not exist
error: cannot find symbol class LocalBroadcastManager
error: cannot find symbol variable RemoteInput
error: cannot find symbol class NotificationCompat
error: package NotificationCompat does not exist
error: package NotificationCompat.Action does not exist
error: cannot find symbol class RemoteInput
error: package RemoteInput does not exist
error: package android.support.annotation does not exist
error: cannot find symbol class RequiresPermission
error: cannot find symbol variable LocalBroadcastManager

[iagormoraes]

Did the lib been upgraded to androidx?

[EskelCz]

Is there a workaround for this? New versions of other libraries require us to upgrade to AndroidX and then we're stuck not able to build, because of this issue. :( Version 6 feels like it could take months.

I thought this is going to be solved by jetifier... but I have it enabled and still firebase is giving me these errors.

---

Edit: For anyone else, the workaround is this:
Add gradle.properties into the android folder of each incompatible module, with this content:

android.useAndroidX=false
android.enableJetifier=false

[mikehardy]

• version 6 will take months, that's public information
• the AndroidX conversion performed by jetifier is not possible for dependencies included by source, and by default react-native includes things via source inclusion - jetifier only transforms jars/aars
• the community in general is discussing how to handle this since react-native 0.60 will be AndroidX and that starts to move all the libraries. You will likely want to follow the issue: AndroidX Migration Plan react-native-community/discussions-and-proposals#129

My best guess now is that react-native libraries will need to be delivered as AARS so jetifier can work forwards (for those libraries that have not converted, like react-native-firebase v5) and with an support-library compatibility AAR distributed for those apps that can't convert.

You could try packaging the react-native-firebase v5 code into a JAR and adding it as a local dependency yourself if you like, jetifier would work then.

[mikehardy]

Interesting workaround by the way - you could use patch-package (works really really well) to automate that patch if/until libraries adopt it, if it works well

[Salakar]

Interesting workaround by the way - you could use patch-package (works really really well) to automate that patch if/until libraries adopt it, if it works well

Yerp, for example this is how people can use v6 now without AndroidX if they need to, here's the patch I've been recommending:

diff --git a/node_modules/@react-native-firebase/app/android/gradle.properties b/node_modules/@react-native-firebase/app/android/gradle.properties
index d015431..e69de29 100644
--- a/node_modules/@react-native-firebase/app/android/gradle.properties
+++ b/node_modules/@react-native-firebase/app/android/gradle.properties
@@ -1,2 +0,0 @@
-android.useAndroidX=true
-android.enableJetifier=true
\ No newline at end of file
diff --git a/node_modules/@react-native-firebase/app/android/src/main/java/io/invertase/firebase/app/ReactNativeFirebaseAppRegistrar.java b/node_modules/@react-native-firebase/app/android/src/main/java/io/invertase/firebase/app/ReactNativeFirebaseAppRegistrar.java
index 521a2e0..d63afae 100644
--- a/node_modules/@react-native-firebase/app/android/src/main/java/io/invertase/firebase/app/ReactNativeFirebaseAppRegistrar.java
+++ b/node_modules/@react-native-firebase/app/android/src/main/java/io/invertase/firebase/app/ReactNativeFirebaseAppRegistrar.java
@@ -17,7 +17,7 @@ package io.invertase.firebase.app;
  *
  */
 
-import androidx.annotation.Keep;
+import android.support.annotation.Keep;
 
 import com.google.firebase.components.Component;
 import com.google.firebase.components.ComponentRegistrar;
diff --git a/node_modules/@react-native-firebase/app/android/src/main/java/io/invertase/firebase/common/ReactNativeFirebaseEventEmitter.java b/node_modules/@react-native-firebase/app/android/src/main/java/io/invertase/firebase/common/ReactNativeFirebaseEventEmitter.java
index 5b1726b..5970656 100644
--- a/node_modules/@react-native-firebase/app/android/src/main/java/io/invertase/firebase/common/ReactNativeFirebaseEventEmitter.java
+++ b/node_modules/@react-native-firebase/app/android/src/main/java/io/invertase/firebase/common/ReactNativeFirebaseEventEmitter.java
@@ -19,7 +19,7 @@ package io.invertase.firebase.common;
 
 import android.os.Handler;
 import android.os.Looper;
-import androidx.annotation.MainThread;
+import android.support.annotation.MainThread;
 import android.util.Log;
 
 import com.facebook.react.bridge.Arguments;
diff --git a/node_modules/@react-native-firebase/app/android/src/main/java/io/invertase/firebase/common/ReactNativeFirebaseInitProvider.java b/node_modules/@react-native-firebase/app/android/src/main/java/io/invertase/firebase/common/ReactNativeFirebaseInitProvider.java
index 42fec16..fcf0c42 100644
--- a/node_modules/@react-native-firebase/app/android/src/main/java/io/invertase/firebase/common/ReactNativeFirebaseInitProvider.java
+++ b/node_modules/@react-native-firebase/app/android/src/main/java/io/invertase/firebase/common/ReactNativeFirebaseInitProvider.java
@@ -23,7 +23,7 @@ import android.content.Context;
 import android.content.pm.ProviderInfo;
 import android.database.Cursor;
 import android.net.Uri;
-import androidx.annotation.Nullable;
+import android.support.annotation.Nullable;
 
 import javax.annotation.OverridingMethodsMustInvokeSuper;
 

Took me ~5 mins to generate that, if people really need something then there are ways 🙃 for both ways AndroidX removal or AndroidX converting.

---

Version 6 feels like it could take months.

If more people contributed this would go a lot quicker. I myself am majorly burnt out working on v6 but I'm still going, hearing stuff like this isn't motivating me I can tell you that. 😩 There are only 2 maintainers working on this + @mikehardy actively helping out with issues, testing & triage.

If anyone wants it quicker then I'd suggest contributing time or donating to pay for other contributors time. Not to rant though, I just genuinely wish more people contributed, /dreams

[mikehardy]

Interestingly, it looks like all your support usage is annotations? Nullable is just a lint hint and the Keep might be implemented in a packaged proguard rule - you might be upgradable to androidx by deleting all references ;-). And yes, always better when the level of contribution rises to the level of requests for help :)

[Salakar]

@mikehardy indeed it's all annotations currently - until we hit messaging & AdMob, at which point the usages goes way beyond that 😞 but doesn't stop them being removed from the other modules I guess 🤔

[mikehardy]

Oh - if it goes beyond that I'd just ignore it then, it's a binary thing you either need androidx or not and if you can't get to zero save the time.

I believe we're going to have a solution soon, there were some good AndroidX + react-native library results last night. We might be down to just making nitty-gritty tooling / CLI decisions shortly

[mikehardy]

Play Services just shipped AndroidX breaking changes - if you must upgrade your android Firebase SDK dependencies

• convert your project to AndroidX via AndroidStudio following their instructions
• npm i jetifier
• hook a call to npx jetify in postinstall (and run it once yourself) to process node_modules source.

Then it will likely work (it worked for me).

---

Update 20190811 - To be clear on one thing - there is a change on the tip of the v5.x.x branch that is unreleased (it will be in 5.5.7) that allows for better library specification for AndroidX in react-native 0.60 - I use the branch reference as my dependency currently: https://github.com/mikehardy/rnfbdemo/blob/master/make-demo.sh#L12

#2476

But everything continues to work for me, I have successfully completed a migration to react-native 0.60.4 + AndroidX + Cocoapods and it hurt to do, but it all works with issues in react-native-firebase fixed along the way. Cheers

[matthall00]

Play Services just shipped AndroidX breaking changes - if you must upgrade your android Firebase SDK dependencies

• convert your project to AndroidX via AndroidStudio following their instructions
• npm i jetifier
• hook a call to npx jetify in postinstall (and run it once yourself) to process node_modules source.

Then it will likely work (it worked for me).

May I say, THANK YOU?
After merging to AndroidX last week, I was still having compile errors from two dependencies: ':react-native-image-picker' & ':react-native-firebase'
Based on your tip, I ran
npm i jetifier
then I ran
npx jetify
That was all I did, and now the following commands will build successfully without error, when they were not previously.
react-native run-android
./gradlew lint
./gradlew assembleRelease

I seem to finally be back on track to finishing my app now after the breaking changes I discovered last Tuesday.

So again, I thank you.

[mikehardy]

You’re welcome! Glad it helped. Remember to hook the jetifier call in package.json postinstall or you’ll blow up unexpectedly again after any module upgrades :-)

[michaelkowalski]

@EskelCz you saved my live 👍 I'm new to the "switching to androidX" mess and spend a few evenings trying to fix the build (in an app that has to be on Google Play on Monday...), thanks!

[mikehardy]

@michaelkowalski replying to say that @EskelCz solution is out of date and I would not recommend it. Altering things in node_modules is a last resort, and even if you did it you would want to use patch_package. The current community recommendation for an AndroidX migration is to use Android Studio to migrate your current app, and then to use the jetifier npm package with a hook to jetify in your postinstall to maintain the migration in dependent packages source if new versions come down or you install new packages

[michaelkowalski]

@mikehardy thanks for your reply! Yes, I saw the rest of the discussion and agree that it's far from the best solution. However for a quick fix it's great because it lets me generate the apk. After the Monday release I will certainly come back here and fix the issue in a more elegant way :)

EDIT: ok, I did it now ;) works like a charm. Thanks for the library! However I had to install jetifier by yarn, the npm way led me to not being able to execute the command.

[StuartMorris0]

The issue still persists for me, I am using androidX and enableJetifier

android.useAndroidX=true
android.enableJetifier=true

Packages:

    "react-native-fbsdk": "^0.10.1",
    "react-native-firebase": "^5.5.4",

I am now only getting three errors:

I've added jetifier and run npx jetify once, I've also added as a postinstall hook for future. If I got to migrate to AndroidX it confirms there are no more file changes required.

Any other thoughts on this @mikehardy, Thank you

[mikehardy]

I am unable to reproduce - works for me with jetifier
clone that and go JETIFY=true ./make-demo.sh in the directory, compiles fine?
mikehardy/rnfbdemo@580d508

[mayermatheus]

I'm having the same problem with @StuartMorris0

[Juman8]

I worked with update core android from normal to androidX lib
You can see: https://developer.android.com/jetpack/androidx/migrate

[anhtuank7c]

I would say upgrade core to implementation 'com.google.firebase:firebase-core:17.0.0' beside using jetifier works for me

[Rumidom]

Manually changing all the deprecated Imports to the new Androidx ones worked for me:
Migrating to AndroidX

[mikehardy]

You guys, the jetifier javascript package does that for you. Or, you can manually change the imports on every new install of every new version on every new machine - your choice I suppose?

[ErnesII]

The two commands that @mikehardy suggested worked for me.
In my package.json I added those commands:

 "scripts": {
        "postinstall": "npm i jetifier && npx jetify"
    }

To make this work just delete node_module folder(rm -rf node_modules) and npm install.

If this does not work for you, you can add your own script and added it in "postinstall", Eg:

 "scripts": {
        "postinstall": "node ./scripts/packageFixer.js"
    }

and your packageFixer.js file is going to look like this:

const fs = require('fs');
filePath = './node_modules/react-native-firebase/android/src/main/java/io/invertase/firebase/messaging/RNFirebaseMessaging.java',
codeToFind = /android\.support\.v4\.content\.LocalBroadcastManager/;
replacement = 'androidx.localbroadcastmanager.content.LocalBroadcastManager';
fileContent = fs.readFileSync(filePath,'utf8');
fs.writeFileSync(filePath, fileContent.replace(codeToFind, replacement), { encoding: 'utf8' });

This approach requires more work but can help you. You will need to repeat this script(not file) for each file that needs androidx

[ccorcos]

I'm still stuck on these dependency issues. Not sure what the cause of it is, but it only started once I upgraded to RN 60.

ERROR: Unable to resolve dependency for ':react-native-firebase@debug/compileClasspath': Could not resolve com.google.code.findbugs:jsr305:{strictly 3.0.0}.
Show Details
Affected Modules: android-react-native-firebase


ERROR: Unable to resolve dependency for ':react-native-firebase@debug/compileClasspath': Could not resolve com.squareup.okhttp:okhttp:{strictly 2.5.0}.
Show Details
Affected Modules: android-react-native-firebase

[OleksandrKucherenko]

subprojects {
    configurations.all {
        // exclude OLD versions of OKHTTP library
        exclude group: 'com.squareup.okhttp', module: 'okhttp'

        // exclude rxJava v1.xxx
        exclude group: 'io.reactivex', module: 'rxjava'
        exclude group: 'io.reactivex', module: 'rxandroid'

        resolutionStrategy {
            failOnVersionConflict()
            preferProjectModules()

            eachDependency { details ->

                /* Override by group and library names */
                def name = "${details.requested.group}:${details.requested.name}"
                switch (name) {
                    // https://github.com/square/okhttp/blob/master/CHANGELOG.md
                    case 'com.squareup.okhttp3:okhttp':
                        /* Latest low level HTTP communication lib */
                        details.useVersion '3.12.1'
                        break

                    /* API compatible, https://medium.com/square-corner-blog/okio-2-6f6c35149525 */
                    case 'com.squareup.okio:okio': details.useVersion '2.1.0'; break

                    case 'com.google.code.findbugs:jsr305': details.useVersion '3.0.2'; break
                    case 'androidx.appcompat:appcompat': details.useVersion '1.0.2'; break
                    case 'androidx.core:core': details.useVersion '1.0.1'; break
                    case 'androidx.vectordrawable:vectordrawable': details.useVersion '1.0.1'; break
                }
            }
        }
    }
}

@ccorcos ^ - try such overrides for gradle dependencies

[mikehardy]

@OleksandrKucherenko that is some serious groovy code for gradle! It looks right (except maybe you could bump gradle to 3.12.3 (vs 3.12.1) - it is the latest that is still compatible down to API16 (for react-native)

May I ask you to share your react-native native module dependency list so I could get an idea of which libraries are causing such conflicts? Because with my dependency list I don't have conflicts. I suspect maybe code-push or expokit but I'd like to see. Thanks!

[OleksandrKucherenko]

@mikehardy In my case overrides used for the project that has a dependency to ~20 react-native packages. Unfortunately, not all modules are updated to the latest versions, or even have a version that is compatible with AndroidX.

that why born this code with global overrides, that deeply force versions of a specific java/android libs in all configurations.

Most issues with RN 0.6x and AndroidX were in alignment/sync of different configurations used in the project. After such override all errors from build plugins, versions mismatch are gone. BUT it quite risky, no one guaranty backward compatibility (exception is only okhttp lib).

So test your project carefully, upgrade version of each dependency and "commit" the result if app running well.

[whtlnv]

I just spent couple days migrating our whole app from RN 0.53 to 0.60.5.

The example provided by @mikehardy was a life saver.

At one point I was doing:

yarn add 3rd-party-library
rm -rf node_modules
rm yarn.lock
yarn
npx jetify
npx react-native run-android

with every dependency in the project. Probably over the top, but after 2 days of getting random gms dependency issues, I didn't care. That worked.

Thanks @mikehardy, you are the man!

[mikehardy]

Glad that helped, the rn60 upgrade is rough but your project is probably sparkly clean now ;-) - I know mine was pretty spiffy when I was done with it

[pavithra2110]

Is there a workaround for this? New versions of other libraries require us to upgrade to AndroidX and then we're stuck not able to build, because of this issue. :( Version 6 feels like it could take months.

I thought this is going to be solved by jetifier... but I have it enabled and still firebase is giving me these errors.

Edit: For anyone else, the workaround is this:
Add gradle.properties into the android folder of each incompatible module, with this content:

android.useAndroidX=false
android.enableJetifier=false

It may cause to other dependencies

[FMaz008]

As this is one of google top result:
Updating React-Native-Firebase to 5.6.0 did solve the issue for me. (Jetify did not solve the problem)