Honor repeatInterval when rescheduling outdated notication #1294
Conversation
[Android] Fix for setting past time in the scheduling.
| newFireDate.add(Calendar.MINUTE, 1); | ||
| break; | ||
| case "hour": | ||
| newFireDate.add(Calendar.HOUR, 1); |
There was a problem hiding this comment.
Would this not still have the same issue as before;
E.g.: I set a fireDate of 3 hours ago, it comes through this logic with a repeatInterval of an hour so this adds an hour but it would still be 2 hours behind - so fires immediately?
In the first instance setting a fireDate in the past shouldn't be allowed on the validations in the JS code - that stops one thing. But; when theRNFirebaseNotificationsRebootReceiver triggers rescheduleNotifications() after a device reboot there's a good chance fireDates can be in the past, so we'd still need to compensate for this anyway 🤔
There was a problem hiding this comment.
You are right, it is not as easy as I initially expected. :|
|
@Salakar would you find time to review this again? |
No description provided.