Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Fix for setting past time in the scheduling. #1276

Merged
merged 1 commit into from
Jul 10, 2018

Conversation

ifsnow
Copy link
Contributor

@ifsnow ifsnow commented Jul 5, 2018

When I try to use scheduling notifications, If fireDate is in the past, the notification is displayed immediately. This is probably not the intended operation. especially, in the process of rebooting.

# fireDate : 2018-07-04 10:00:00, repeatInterval : day

1) 2018-07-05 10:00:00 => OK
2) 2018-07-06 10:00:00 => OK
3) rebooting and register alarm in past time (2018-07-04 10:00:00)
4) 2018-07-06 10:05:00 => Wrong

So time adjustment is required for proper operation.

I hope this helps.

@Salakar Salakar merged commit 886efca into invertase:master Jul 10, 2018
@Salakar
Copy link
Member

Salakar commented Jul 10, 2018

@ifsnow makes sense, thanks for this, will drop a patch release tomorrow with this in it ~v4.3.x


Loving react-native-firebase and the support we provide? Please consider supporting us with any of the below:

@Salakar Salakar self-assigned this Jul 10, 2018
@ifsnow ifsnow deleted the fix-android-schedule-date branch December 17, 2020 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants