Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix URL generation error #8630

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Conversation

SchrodingersGat
Copy link
Member

  • Implement better helper function for handling URL generation
  • Handle errors in said function
  • The solution introduced in [PUI] Url fixes #8615 was insufficient and caused issues when compiled

- Implement better helper function for handling URL generation
- Handle errors in said function
@SchrodingersGat SchrodingersGat added bug Identifies a bug which needs to be addressed refactor Platform UI Related to the React based User Interface labels Dec 6, 2024
@SchrodingersGat SchrodingersGat added this to the 0.17.0 milestone Dec 6, 2024
Copy link

netlify bot commented Dec 6, 2024

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit 128ea11
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/67526cf32b8f860008119ed4
😎 Deploy Preview https://deploy-preview-8630--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (🟢 up 1 from production)
Accessibility: 86 (no change from production)
Best Practices: 100 (no change from production)
SEO: 78 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 70.58824% with 5 lines in your changes missing coverage. Please review.

Project coverage is 84.62%. Comparing base (4e36c7a) to head (128ea11).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/frontend/src/functions/urls.tsx 70.00% 2 Missing and 1 partial ⚠️
...rontend/src/components/buttons/PrintingActions.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8630      +/-   ##
==========================================
- Coverage   84.74%   84.62%   -0.12%     
==========================================
  Files        1190     1190              
  Lines       54296    54297       +1     
  Branches     2055     2057       +2     
==========================================
- Hits        46011    45951      -60     
- Misses       7772     7837      +65     
+ Partials      513      509       -4     
Flag Coverage Δ
pui 69.03% <70.58%> (-0.62%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchrodingersGat SchrodingersGat merged commit 82bce19 into inventree:master Dec 6, 2024
30 checks passed
@SchrodingersGat SchrodingersGat deleted the url-fix branch December 6, 2024 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Identifies a bug which needs to be addressed Platform UI Related to the React based User Interface refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant