Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PUI] Url fixes #8615

Merged
merged 2 commits into from
Dec 2, 2024
Merged

[PUI] Url fixes #8615

merged 2 commits into from
Dec 2, 2024

Conversation

SchrodingersGat
Copy link
Member

  • Refactor URL generation functions to use proper URL generators
  • Fixes issues with malformed (but still "legal") URLs
  • e.g. ApiImage would (prior to this fix) make requests like //media/part/10/attachment.pdf

- Use built-in URL function
- Refactor "admin" button
- Refactor API image
- Refactor printing actions
- Refactor attachment link
@SchrodingersGat SchrodingersGat added refactor Platform UI Related to the React based User Interface labels Dec 2, 2024
@SchrodingersGat SchrodingersGat added this to the 0.17.0 milestone Dec 2, 2024
Copy link

netlify bot commented Dec 2, 2024

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit f564146
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/674d508ee2d9ba0008f5dd37
😎 Deploy Preview https://deploy-preview-8615--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🔴 down 1 from production)
Accessibility: 86 (no change from production)
Best Practices: 100 (no change from production)
SEO: 78 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 58.33333% with 5 lines in your changes missing coverage. Please review.

Project coverage is 84.64%. Comparing base (147ca53) to head (f564146).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...rontend/src/components/buttons/PrintingActions.tsx 0.00% 4 Missing ⚠️
...c/frontend/src/components/plugins/PluginSource.tsx 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8615      +/-   ##
==========================================
+ Coverage   84.62%   84.64%   +0.01%     
==========================================
  Files        1189     1189              
  Lines       54285    54284       -1     
  Branches     2054     2052       -2     
==========================================
+ Hits        45940    45949       +9     
+ Misses       7832     7824       -8     
+ Partials      513      511       -2     
Flag Coverage Δ
pui 69.18% <58.33%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchrodingersGat SchrodingersGat merged commit 21cd285 into inventree:master Dec 2, 2024
28 checks passed
@SchrodingersGat SchrodingersGat deleted the url-fix branch December 2, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform UI Related to the React based User Interface refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants