Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PUI] Fix stock item state rendering #8572

Merged
merged 3 commits into from
Nov 28, 2024

Conversation

matmair
Copy link
Member

@matmair matmair commented Nov 27, 2024

Fix rendering of stock states in dialogues - see #7990

@matmair matmair added bug Identifies a bug which needs to be addressed Platform UI Related to the React based User Interface labels Nov 27, 2024
@matmair matmair added this to the 0.17.0 milestone Nov 27, 2024
@matmair matmair self-assigned this Nov 27, 2024
Copy link

netlify bot commented Nov 27, 2024

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit 8e60eec
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/6746bce6166bd50008554b9f
😎 Deploy Preview https://deploy-preview-8572--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 86 (no change from production)
Best Practices: 100 (no change from production)
SEO: 78 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.55%. Comparing base (368f3b7) to head (8e60eec).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8572      +/-   ##
==========================================
- Coverage   84.57%   84.55%   -0.03%     
==========================================
  Files        1178     1181       +3     
  Lines       53711    53787      +76     
  Branches     2027     2033       +6     
==========================================
+ Hits        45426    45477      +51     
- Misses       7779     7803      +24     
- Partials      506      507       +1     
Flag Coverage Δ
pui 69.05% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchrodingersGat
Copy link
Member

Is rendering of status_custom_key sufficient? Does the value defer to the status value if no "custom" value is provided?

@matmair
Copy link
Member Author

matmair commented Nov 28, 2024

yes, if status_custom_key is not set specifically it returns status

@SchrodingersGat SchrodingersGat merged commit 7478a28 into inventree:master Nov 28, 2024
28 checks passed
@SchrodingersGat SchrodingersGat deleted the switch-state-rendering branch November 28, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Identifies a bug which needs to be addressed Platform UI Related to the React based User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants