Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Stock Status cannot be set from Stock Actions #7990

Open
3 of 6 tasks
gunstr opened this issue Aug 25, 2024 · 8 comments · May be fixed by #8438
Open
3 of 6 tasks

Custom Stock Status cannot be set from Stock Actions #7990

gunstr opened this issue Aug 25, 2024 · 8 comments · May be fixed by #8438
Labels
api Relates to the API bug Identifies a bug which needs to be addressed Platform UI Related to the React based User Interface question This is a question
Milestone

Comments

@gunstr
Copy link

gunstr commented Aug 25, 2024

Please verify that this bug has NOT been raised before.

  • I checked and didn't find a similar issue

Describe the bug*

A configured custom stock status such as "TestState" is not visible in the drop down list in the StockAction modal.

I can set the TestState on an item from the Edit Stock Item modal but I noticed that if then TestState is selected as a filter to the Stock Item list no itmes are visble. I do not know if this is related or maybe it should be a separate issue?

Steps to Reproduce

This test is done on the Demo site only, I have not installed PUI locally yet.

  1. Create a Custom Stock status
  2. Open the Stock Items list, click Stock Actions and select Change Stock Status

image

  1. In the Status dropdown the TestState option is not visible

image

Expected behaviour

It should be possible to set custom stock status also from the Stock Action modal

Deployment Method

  • Docker
  • Package
  • Bare metal
  • Other - added info in Steps to Reproduce

Version Information

InvenTree-Version: 0.17.0 dev
Django Version: 4.2.15
Commit Hash: 6951748
Commit Date: 2024-08-25
Commit Branch: null
Database: postgresql
Debug-Mode: False
Deployed using Docker: True
Platform: Linux-5.15.0-100-generic-x86_64-with
Installer: DOC
nullActive plugins: false

Please verify if you can reproduce this bug on the demo site.

  • I can reproduce this bug on the demo site.

Relevant log output

No response

@gunstr gunstr added bug Identifies a bug which needs to be addressed question This is a question triage:not-checked Item was not checked by the core team labels Aug 25, 2024
@SchrodingersGat SchrodingersGat added old user interface Issues with Old User interface api Relates to the API Platform UI Related to the React based User Interface and removed triage:not-checked Item was not checked by the core team labels Aug 25, 2024
@SchrodingersGat SchrodingersGat added this to the 0.17.0 milestone Aug 25, 2024
@SchrodingersGat
Copy link
Member

@gunstr thanks for reporting, we will have to look into this

@matmair
Copy link
Member

matmair commented Nov 28, 2024

@SchrodingersGat can we move this to 1.0?

@SchrodingersGat
Copy link
Member

@matmair sure, it requires a bit more attention and I would like to get the new release out.

@SchrodingersGat SchrodingersGat modified the milestones: 0.17.0, 1.0.0 Nov 28, 2024
@gunstr
Copy link
Author

gunstr commented Nov 28, 2024

@SchrodingersGat @matmair is your recommendation not to use the cusom states at all until you have worket this trough a bit more?

@SchrodingersGat
Copy link
Member

SchrodingersGat commented Nov 28, 2024

@gunstr I think that for this particular issue, you can manually adjust the stock status per stock item, rather than as a group? That is, via the "edit stock item" dialog

@gunstr
Copy link
Author

gunstr commented Nov 28, 2024

@SchrodingersGat Yes, for the UI related issues that is probably OK. I have seen your discussion on the implementation in general and got a bit worried that updating all current stock items with custom states at this stage might be waste of time - but maybe that would not be the case...

As you might remember from previous discussions I pach my local installations for each upgrde with more relevant status names and I'm really looking forward to skip that and use the custom states instead. A few limitations in the UI is OK as long as there are work arounds.

@gunstr
Copy link
Author

gunstr commented Dec 1, 2024

@gunstr I think that for this particular issue, you can manually adjust the stock status per stock item, rather than as a group? That is, via the "edit stock item" dialog

@SchrodingersGat I mentioned already when I wrote the issue that if I set the TestState on an item from the Edit Stock Item modal and then select TestState as a filter to the Stock Item list no items are visble. I do not find any workaround for this and it makes the Custom States less useful, Do you want me to create a separate issue for this so it does not get lost?

@SchrodingersGat
Copy link
Member

@gunstr yes that does sound like a separate issue - please create a new one with as much information as you cna provide

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Relates to the API bug Identifies a bug which needs to be addressed Platform UI Related to the React based User Interface question This is a question
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants