Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set status when returning from customer #8571

Merged
merged 7 commits into from
Nov 27, 2024

Conversation

SchrodingersGat
Copy link
Member

Allow adjusting stock item status when manually returning from a customer

@SchrodingersGat SchrodingersGat added enhancement This is an suggested enhancement or new feature stock Related to Stock models api Relates to the API Platform UI Related to the React based User Interface labels Nov 26, 2024
@SchrodingersGat SchrodingersGat added this to the 0.17.0 milestone Nov 26, 2024
Copy link

netlify bot commented Nov 26, 2024

Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit 8337b3c
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/67471364d288480008c63eba

Comment on lines +982 to +990
status = serializers.ChoiceField(
choices=stock.status_codes.StockStatus.items(),
default=None,
label=_('Status'),
help_text=_('Stock item status code'),
required=False,
allow_blank=True,
)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This setup will not support custom statuses

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed - I'll loop back to this as part of a general solution to #7990

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 76.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 84.62%. Comparing base (af39189) to head (8337b3c).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/frontend/src/forms/ReturnOrderForms.tsx 0.00% 5 Missing ⚠️
src/backend/InvenTree/stock/models.py 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8571      +/-   ##
==========================================
- Coverage   84.70%   84.62%   -0.09%     
==========================================
  Files        1183     1183              
  Lines       54000    54025      +25     
  Branches     2032     2034       +2     
==========================================
- Hits        45743    45719      -24     
- Misses       7735     7793      +58     
+ Partials      522      513       -9     
Flag Coverage Δ
backend 86.02% <92.00%> (-0.01%) ⬇️
pui 69.18% <0.00%> (-0.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchrodingersGat SchrodingersGat merged commit a48d23b into inventree:master Nov 27, 2024
26 checks passed
@SchrodingersGat SchrodingersGat deleted the return-status branch November 27, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Relates to the API enhancement This is an suggested enhancement or new feature Platform UI Related to the React based User Interface stock Related to Stock models
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants