Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: before_first_request deprecation #958

Merged
merged 7 commits into from
Mar 23, 2024
Merged

fix: before_first_request deprecation #958

merged 7 commits into from
Mar 23, 2024

Conversation

utnapischtim
Copy link
Contributor

@utnapischtim utnapischtim commented May 14, 2023 •
edited
Loading

NOTE:

  • invenio-base and invenio-app have to be released first
  • invenio-administration and invenio-requests have to be released first because of the invenio-theme<3.0.0 restriction

@utnapischtim utnapischtim marked this pull request as draft May 14, 2023 21:29
@utnapischtim utnapischtim mentioned this pull request May 14, 2023
Closed
@utnapischtim utnapischtim force-pushed the add-init-function branch 3 times, most recently from 9089d94 to fdd5f72 Compare May 25, 2023 21:01
@utnapischtim
fix: before_first_request deprecation
ebca2ee
@utnapischtim
init: move record_once into finalize_app
d14b499
@utnapischtim
setup: use api_finalize_app
cc8f325 
* the api_finalize_app is necessary to call the registration function
  which was called by record_once also on the create_api factory
@utnapischtim
menu: use current_menu
0bb59f9
@kpsherva kpsherva marked this pull request as ready for review March 22, 2024 09:49
@kpsherva kpsherva merged commit 0b376bf into inveniosoftware:master Mar 23, 2024
4 checks passed
@ptamarit ptamarit mentioned this pull request Apr 15, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@utnapischtim @kpsherva