Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: community theme and menus visibility #1126

Conversation

ptamarit
Copy link
Member

@ptamarit ptamarit commented Apr 15, 2024

❤️ Thank you for your contribution!

Description

We noticed that the community CSS theme was not mapped, and found out that the problem was related to the pull request #958.

It is likely that the pull request was authored before other changes were introduced, and that rebasing accidentally rolled back these recent changes (since the PR consists of moving code between different files).

The changes which got rolled back by mistake are:

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Third-party code

If you've added third-party code (copy/pasted or new dependencies), please reach out to an architect.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@ptamarit ptamarit force-pushed the fix-community-theme-and-menus-visibility branch from aed1910 to e200aec Compare April 15, 2024 14:38
@ptamarit ptamarit requested a review from slint April 15, 2024 14:47
@slint slint merged commit 83d5c17 into inveniosoftware:master Apr 15, 2024
4 checks passed
@ptamarit ptamarit deleted the fix-community-theme-and-menus-visibility branch April 16, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants