Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix __FEATURE_ESM_BUNDLER_WARN__ flag can not be configured #514

Merged
merged 1 commit into from
May 29, 2021

Conversation

PeterAlfredLee
Copy link
Member

The __FEATURE_ESM_BUNDLER_WARN__ is replaced to be true in rollup.config.js, which make it being impossible to be configured.

Fix #461

@kazupon
Copy link
Member

kazupon commented May 28, 2021

Thank you for your PR!

This flag is no longer needed, so please fix the following code and documentation as well!
so we no longer need this flag, please also fix the code found in the following search results! 🙏

https://github.com/intlify/vue-i18n-next/search?q=__FEATURE_ESM_BUNDLER_WARN__

@PeterAlfredLee PeterAlfredLee force-pushed the fix_suppress_warning branch from 6e9a0de to 2d3c37c Compare May 29, 2021 00:58
@PeterAlfredLee
Copy link
Member Author

I see. I pushed a new commit. Please have a look. :-)

@kazupon kazupon added the Type: Breaking Includes backwards-incompatible fixes label May 29, 2021
Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kazupon kazupon merged commit 3b4d45e into intlify:master May 29, 2021
@rstoenescu
Copy link
Contributor

rstoenescu commented May 30, 2021

@kazupon & @PeterAlfredLee Thanks for fixing this! Cheers from Quasar!

@PeterAlfredLee
Copy link
Member Author

Thanks for fixing this! Cheers from Quasar!

I'm glad this helps. :-)

@PeterAlfredLee PeterAlfredLee deleted the fix_suppress_warning branch May 31, 2021 01:18
kazupon added a commit that referenced this pull request May 1, 2022
kazupon added a commit that referenced this pull request May 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Breaking Includes backwards-incompatible fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to suppress warning with __FEATURE_ESM_BUNDLER_WARN__ ?
3 participants