Skip to content

Commit

Permalink
remove __FEATURE_ESM_BUNDLER_WARN__ flag. (#514)
Browse files Browse the repository at this point in the history
  • Loading branch information
PeterAlfredLee authored May 29, 2021
1 parent a14b772 commit 3b4d45e
Show file tree
Hide file tree
Showing 5 changed files with 1 addition and 12 deletions.
3 changes: 1 addition & 2 deletions jest.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,7 @@ module.exports = {
__ESM_BROWSER__: false,
__NODE_JS__: true,
__FEATURE_FULL_INSTALL__: true,
__FEATURE_LEGACY_API__: true,
__FEATURE_ESM_BUNDLER_WARN__: true
__FEATURE_LEGACY_API__: true
},

// The maximum amount of workers used to run your tests. Can be specified as % or a number. E.g. maxWorkers: 10% will use 10% of your CPU amount + 1 as the maximum worker number. maxWorkers: 2 will use a maximum of 2 workers.
Expand Down
1 change: 0 additions & 1 deletion packages/global.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ declare let __FEATURE_PROD_VUE_DEVTOOLS__: boolean
declare let __FEATURE_PROD_INTLIFY_DEVTOOLS__: boolean
declare let __FEATURE_LEGACY_API__: boolean
declare let __FEATURE_FULL_INSTALL__: boolean
declare let __FEATURE_ESM_BUNDLER_WARN__: boolean

// for tests
declare namespace jest {
Expand Down
4 changes: 0 additions & 4 deletions packages/vue-i18n/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,6 @@ The build will work without configuring these flags, however it is **strongly re

Note: the replacement value **must be boolean literals** and cannot be strings, otherwise the bundler/minifier will not be able to properly evaluate the conditions.

## Other Feature Flags

- `__FEATURE_ESM_BUNDLER_WARN__` (Suppress / Not suppress feature flags recommended warnings in build for `esm-bulder`)

## :copyright: License

[MIT](http://opensource.org/licenses/MIT)
4 changes: 0 additions & 4 deletions packages/vue-i18n/src/misc.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,6 @@ export function initFeatureFlags(): void {
getGlobalThis().__INTLIFY_PROD_DEVTOOLS__ = false
}

if (__DEV__ && typeof __FEATURE_ESM_BUNDLER_WARN__ === 'boolean') {
needWarn = __FEATURE_ESM_BUNDLER_WARN__
}

if (__DEV__ && needWarn) {
console.warn(
`You are running the esm-bundler build of vue-i18n. It is recommended to ` +
Expand Down
1 change: 0 additions & 1 deletion rollup.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,6 @@ function createReplacePlugin(
__FEATURE_PROD_INTLIFY_DEVTOOLS__: isBundlerESMBuild
? `__INTLIFY_PROD_DEVTOOLS__`
: false,
__FEATURE_ESM_BUNDLER_WARN__: true,
preventAssignment: false,
...(isProduction && isBrowserBuild
? {
Expand Down

0 comments on commit 3b4d45e

Please sign in to comment.