[core-service] Rename enable_http to allow_http_base_urls

[brandoncorrea]

• Rename all usages of EnableHTTP to AllowHTTPBaseUrls
• Add command-line flag, allow_http_base_urls
• Deprecate command-line flag, enable_http, in favor of allow_http_base_urls

Clients of core-service will need to update the command-line parameter, enable_http to allow_http_base_urls, namely Monitoring – core_service.sh L21/33.

Created for Issue #788

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: brandoncorrea / name: Brandon Correa (84dcf73, 3158cab, f989cde, 1025aa6, 925b20d)

[barroco]

Thank you @brandoncorrea for your contribution.
In case the old flag is provided, core-service will fail with an unrecognized flag error.
Since this flag should only be used for development purpose, I think it should be ok as-is. However, the flag is used in the context of the monitoring repository tests and we will need to coordinate this change.
Therefore, we will need to wait a bit before merging this PR. An option to not wait would be to keep backward compatibility and keep -enable_http possible with a deprecation warning, migrate the monitoring repository and clean it up after.
I think keeping backward compatibility would be great if you have time for that.

[brandoncorrea]

I'm in favor of supporting backwards compatibility. I'll update the PR accordingly.

[brandoncorrea]

@barroco Both enable_http and allow_http_base_urls flags are now supported.

[barroco]

Thank you very much for the change! This is looking great. A last detail would be to print a warning if the old flag is used as well as update the description of the usage description of the old flag indicating it is deprecated in favour of the new one.

[brandoncorrea]

A warning has been added when the old flag is set, preferring the new flag if both are set.

Looking further into how flags work, I realized my first backwards-compatibility code wasn't technically correct because flags aren't initialized at the head of the file (everything is default). I moved this to main where logging and flags have already been initialized.

[barroco]

Thanks @brandoncorrea for your efforts. Last thing, could you please update the PR description to reflect the latest changes ?

[brandoncorrea]

@barroco description has been updated!