Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename AllowHTTP flag to be more clear #788

Open
BenjaminPelletier opened this issue Jun 10, 2022 · 0 comments
Open

Rename AllowHTTP flag to be more clear #788

BenjaminPelletier opened this issue Jun 10, 2022 · 0 comments
Labels
dss Relating to one of the DSS implementations feature Issue would improve software P3 Lower priority

Comments

@BenjaminPelletier
Copy link
Member

I feel like this flag may benefit to be renamed since it is only used to disable URLs validation. I would propose to rename it as AllowHTTP or AllowHTTPBaseUrls to prevent confusion. Indeed, I got mislead thinking that this was linked to the listening protocol of the DSS server.

Originally posted by @barroco in #784 (comment)
@BenjaminPelletier BenjaminPelletier mentioned this issue Jun 10, 2022
Merged
@BenjaminPelletier BenjaminPelletier added P2 Normal priority feature Issue would improve software P3 Lower priority dss Relating to one of the DSS implementations and removed P2 Normal priority labels Sep 20, 2022
@brandoncorrea brandoncorrea mentioned this issue Jul 30, 2024
Merged
barroco pushed a commit that referenced this issue Aug 8, 2024
@brandoncorrea
[core-service] Rename enable_http to allow_http_base_urls (#1061)
b6ad9f9 
- Rename all usages of EnableHTTP to AllowHTTPBaseUrls
- Add command-line flag, allow_http_base_urls
- Deprecate command-line flag, enable_http, in favor of allow_http_base_urls

Clients of core-service will need to update the command-line parameter, enable_http to allow_http_base_urls, namely Monitoring – core_service.sh L21/33.

Created for Issue #788
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dss Relating to one of the DSS implementations feature Issue would improve software P3 Lower priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@BenjaminPelletier