[PB-2666] use hybrid encryption in index.ts #1445
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sg-gs
approved these changes
Jan 30, 2025
There was a problem hiding this comment.
Running the QA on this one.
Checklist
Private sharing:
-
Sharing content from the new version to the old one- This cannot be done as the new uses a PQC approach the old one cannot understand
- Sharing content from the new version to the new version
- User A shares content with user B, user B can see the content.
- Sharing content from the old version to the new version
- User C (old version, without Kyber) shares content with user B (using the new version)
- User C (in the old version) can open shares in the new version that were generated using only the old version
Deploying drive-web with
|
| Latest commit: |
dbf459c
|
| Status: | ⚡️ Build in progress... |
CandelR
reviewed
Jan 31, 2025
| }); | ||
|
|
||
| const encryptedMnemonicInBase64 = btoa(encryptedMnemonic as string); | ||
| const encryptionAlgorithm = publicKyberKey !== '' ? 'hybrid' : 'ed25519'; |
There was a problem hiding this comment.
Add this hardcoded string to constants
Comment on lines
120
to
+121
| publicKey = publicKeyResponse.publicKey; | ||
| if (publicKeyResponse.keys) { |
There was a problem hiding this comment.
I understand that the backend keeps sending the public key in the publicKey field for pre-hybrid users and in keys.ecc.publicKey for new hybrid users, is that right?
There was a problem hiding this comment.
it sends it for everyone now, but for pre-hybrid users kyber key is null (unless they login recently)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Switch encryption to a hybrid version with Kyber and ensure that it works as expected
Related Issues
Relates to PB-2666
Related Pull Requests
Checklist
How Has This Been Tested?
Unit tests:
keys)Additional Notes