Switch to hybrid enc in workspacesStore #1413
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
CandelR
reviewed
Jan 10, 2025
| const { mnemonic, publicKey } = user; | ||
| const { mnemonic } = user; | ||
| const publicKey = user.keys.ecc.publicKey; | ||
| const publicKyberKey = user.keys.kyber.publicKey; |
There was a problem hiding this comment.
do the kyber and ecc fields always exist, right? If not, this may give error
There was a problem hiding this comment.
@CandelR they are defined in the structure as mandatory fields. Encryption should work even if kyber key is '' (empty) - see the test. But if ecc key is empty, the encryption will throw an error. There was no check before, but I can add it
There was a problem hiding this comment.
@CandelR Added test for an empty publicKey
…nto feat/switch_to_kyber_enc_workspacesStore
…to feat/switch_to_kyber_enc_workspacesStore
Deploying drive-web with
|
| Latest commit: |
e38ff6e
|
| Status: | ⚡️ Build in progress... |
7 tasks
7 tasks
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Switch encryption to a hybrid version with Kyber and ensure that it works as expected
Related Issues
Relates to PB-2666
Related Pull Requests
Checklist
How Has This Been Tested?
Unit tests:
Additional Notes