Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add analytics to pager navigation buttons #10147

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sbwhitt
Copy link
Collaborator

@sbwhitt sbwhitt commented Dec 13, 2024

Precedes #9742

Add analytics to the pager portion of the author search page prior to redesign. If the naming isn't quite right please let me know. I set the intermediate page links to their page numbers.

Technical

Testing

Screenshot

Stakeholders

@RayBB

@sbwhitt sbwhitt requested a review from RayBB December 13, 2024 20:24
Copy link
Collaborator

@RayBB RayBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor suggestion to change but otherwise this looks fantastic!

openlibrary/macros/Pager.html Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Waiting on Me
Development

Successfully merging this pull request may close these issues.

2 participants