-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve styling for author page with regard to search bar #9742
Comments
@sbwhitt I think yours is a big improvement! At the same time, I think we should drastically simplify the design long term. Just have next/prev (and maybe first/last). To make it beyond my opinion I'd recommend the following:
In short, I'd support you making a PR for your proposed changes :) |
I agree it could be simplified further. I would like to remove the text like some of the examples you showed, and maybe reduce the amount of page numbers as well. If you want to assign to me I can keep messing with it and put up a PR in a bit. |
@sbwhitt I assigned you. I know it'll be a slow next month or so as the team is away for the holidays but it would be awesome if you wanted to come up with some simpler mockups. Also if you want to do an analytics PR maybe we can sneak that out before the holidays to collect data and justify simplifying it. If you need an analytics example I have a recent PR for wikidata analytics. |
That's totally fine. I am just getting back into things so no rush. Also, I'd be up for that. I haven't worked with that before so an example would be helpful. Thanks for the help! |
#10069 is the example. Might have to put a little thinking into what they keys will be for each state. I think they probably should be relative like the words are the words but the others could be +1 +2 +3 or something like that to see how often people are skipping ahead or back more than one from where they currently are. |
Problem
There are several issues on the author search page in regards to the search bar.
Evidence / Screenshot
Relevant URL(s)
https://openlibrary.org/authors/OL31676A/Noam_Chomsky
https://openlibrary.org/authors/OL8278562A/Morgan_G._Ames
Reproducing the bug
Issues on desktop:
Issues on mobile:
Context
n/a
Notes from this Issue's Lead
Proposal & constraints
We'll need someone with a careful eye at design to take a look at this one.
Related files
Stakeholders
Instructions for Contributors
The text was updated successfully, but these errors were encountered: