Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add namespace for AGP <4.2 support #152

Merged
merged 4 commits into from
Jan 25, 2024
Merged

fix: add namespace for AGP <4.2 support #152

merged 4 commits into from
Jan 25, 2024

Conversation

Looskie
Copy link
Contributor

@Looskie Looskie commented Jan 14, 2024 •
edited
Loading

For AGP versions greater than 4.2, it requires a namespace. Without this, versions higher than AGP 4.2 will result in this error

* What went wrong:
A problem occurred configuring project ':intercom_intercom-react-native'.
  ...
   > Namespace not specified. Specify a namespace in the module's build file.

Hope you have a good day!

@prithivraj prithivraj enabled auto-merge (squash) January 24, 2024 02:00
@prithivraj prithivraj merged commit 8935005 into intercom:main Jan 25, 2024
2 of 5 checks passed
@Looskie Looskie deleted the patch-1 branch January 25, 2024 19:47
@Looskie Looskie mentioned this pull request Feb 26, 2024
Draft
uddish pushed a commit that referenced this pull request Mar 13, 2024
@Looskie @uddish
fix: add namespace for AGP <4.2 support (#152)
cbb2492 
* fix: add namespace for AGP <4.2 support

* chore: backwards compatibility

* fix: rm package from manifest for gradle 8.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prithivraj prithivraj prithivraj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Looskie @prithivraj