fix: add namespace for AGP <4.2 support (#152)

* fix: add namespace for AGP <4.2 support * chore: backwards compatibility * fix: rm package from manifest for gradle 8.0
intercom · Jan 25, 2024 · 8935005 · filipef101 · Feb 26, 2024 · Looskie
1 parent 96aa834
commit 8935005
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 5 deletions.
diff --git a/android/build.gradle b/android/build.gradle
@@ -23,6 +23,12 @@ def safeExtGet(prop, fallback) {
 }
 
 android {
+    // Compatibility for AGP v. <4.2/Gradle 8
+    def agpVersion = com.android.Version.ANDROID_GRADLE_PLUGIN_VERSION.tokenize('.')[0].toInteger()
+    if (agpVersion >= 7) {
+      namespace 'com.intercom.reactnative'
+    }
+
     compileSdkVersion safeExtGet('IntercomReactNative_compileSdkVersion', 34)
     defaultConfig {
         minSdkVersion safeExtGet('IntercomReactNative_minSdkVersion', 21)
@@ -40,9 +46,12 @@ android {
     lintOptions {
         disable 'GradleCompatible'
     }
-    compileOptions {
-        sourceCompatibility JavaVersion.VERSION_1_8
-        targetCompatibility JavaVersion.VERSION_1_8
+
+    if (agpVersion < 8) {
+      compileOptions {
+          sourceCompatibility JavaVersion.VERSION_1_8
+          targetCompatibility JavaVersion.VERSION_1_8
+      }
     }
 }
 

diff --git a/android/src/main/AndroidManifest.xml b/android/src/main/AndroidManifest.xml
@@ -1,4 +1,3 @@
-<manifest xmlns:android="http://schemas.android.com/apk/res/android"
-          package="com.intercom.reactnative">
+<manifest xmlns:android="http://schemas.android.com/apk/res/android">
 
 </manifest>