[VP] Use forward_references as the reference for ADI

[Jister]

VAAPI define forward_references as past referene frame, but vphal regard forward reference as future reference frame. This change will only correct the behavior in DDI level to map forward_references to VPHAL_SURFACE.pBwdRef, and backward_references to VPHAL_SURFACE.pFwdRef

[chcore]

Will this be merged at some point? It looks like I can't use hardware deinterlacing on Tiger Lake until it is.

[smp79]

Hope this will get merged some day.

[XinfengZhang]

@FurongZhang , please take a look, if no other concern , we should start the merging process. suppose validation reference also need be updated.

[chcore]

Almost 2 years now since the issue has been reported, with no fix in sight.

[bkuhls]

ping

[FurongZhang]

The original author will not work on this. I picked up this and will follow up. Will run full test and check if there is any regression.

[chcore]

Any plans to merge this? I would love to stop having to compile the driver myself

[heitbaum]

@FurongZhang - as fyi - this has been part of the LibreELEC code base for 12 months now: LibreELEC/LibreELEC.tv@7fc1462 Hope to see it in the official release in the near future.

[smp79]

Still no merge?

[bkuhls]

gentle ping as a reminder for this PR ;)

[smp79]

I don't understand either why this PR is ignored (for years now). ADI is an important feature which is completely broken at this point.

[bkuhls]

monthly ping as a reminder for this PR ;)

[bkuhls]

monthly ping as a reminder for this PR ;)

[LhGu]

It is in our known issues list. https://github.com/intel/media-driver/wiki/Existing-Known-Issue-List#video-processing-forward-and-backward-reference.

[chcore]

@LhGu by "close this pr" do you mean you are going to merge it? If not, can you please explain why?

[bkuhls]

monthly ping as a reminder for this PR ;)

[bkuhls]

monthly ping as a reminder for this PR ;)

[FurongZhang]

Hi @Simon566 , @bkuhls , @chcore , @smp79 ,
I know ADI is an important feature, hence, Jason provided the patch for this issue a few years ago. We took a few actions to handle this in the past few years, 1) Suggest the developers to pick this PR if they really needs this PR; 2) We put this issue into our known issue list.
In this thread, I saw you took the effort to push this issue. I have a few questions, may I know what product / open source community you are working on? I am trying to understand your request from business point view.

Best regards,
Furong

[Simon566]

Hi,

any user thats using a intel x86 system with IGPU for watching satellite TV will have issues with interlacing. Also, there is quite alot older video content out there which is interlaced !

in my case its a Kodi /XBMC box on a N5105 CPU. Others are using Libreelec which is basically also the same (XBMC/Kodi) on X86, but they patch the intel driver by default in their repos.

Im already happy with BOB deinterlacing , but advanced deinterlace would even be better

regards,
Simon

[smp79]

in my case its a Kodi /XBMC box on a N5105 CPU

N5105 (Jasper Lake) does not support advanced deinterlacing anyway (hardware limitation), so you are not affected by this issue. The issue affects Tiger Lake/Alder Lake and newer platforms.

[Simon566]

possible , but without the mentioned patch , which LibreElec uses , VAAPI BOB doesnt work as well ....

[smp79]

BOB looks much worse than MCDI or any other high quality DI method. In your case I recommend disabling VAAPI hw decoding and use software (ff-h264) decoding with BWDIF deinterlace method. BWDIF looks just as good as hardware MCDI.

[Simon566]

BWDIF hasnt arrived in kodi yet. and decoding h265 in SW is too slow

[smp79]

BWDIF is the default sw deinterlace method since Kodi 21. VAAPI hw acceleration can be disabled only for h264/mpeg-2.

[Simon566]

oh ok , i got kodi 21 , but i only see bob / deinterlace / vaapi bob

[smp79]

Disable VAAPI acceleration for h264 and mpeg-2, it would default to bwdif.

[Simon566]

this doesnt work , 4k is too much in h264

[orryverducci]

Hi @Simon566 , @bkuhls , @chcore , @smp79 , I know ADI is an important feature, hence, Jason provided the patch for this issue a few years ago. We took a few actions to handle this in the past few years, 1) Suggest the developers to pick this PR if they really needs this PR; 2) We put this issue into our known issue list. In this thread, I saw you took the effort to push this issue. I have a few questions, may I know what product / open source community you are working on? I am trying to understand your request from business point view.

Best regards, Furong

@FurongZhang I refer you to my comment on the issue.

This effects everyone who is trying to deinterlace HD or SD broadcast TV content using modern Intel iGPU's and this media driver. Adaptive deinterlacing doesn't work properly and results in a noticeably jittery picture. This worked correctly on the old drivers, and on this driver with this PR.

Naturally the open source media server projects and their users notice this more as they are playing and watching live and recorded broadcast TV channels. Those projects have been able to work around this by providing distributions that include this driver with this PR. But that doesn't help users who are using standard distributions (e.g. Ubuntu) with standard media player or transcoding applications.

As you'll see from my comment this affects both home users and broadcasters (i.e. businesses and customers of Intel server products).

Given this Intel really need to provide a fix for this, otherwise playback or transcoding of interlaced video will remain broken for the majority of users, regardless of software used.

[FurongZhang]

@orryverducci , I fully understood your request.

[xxzandy]

Ping from me. Broadcast TV is still very common media. Without ADI, Intel GPU cannot be used for transcoding with high quality.

[Simon566]

ping pong

im used to a different kind of quality from intel, wether its Raptor Lake CPUs or their drivers .

[FurongZhang]

Adding @jiafengy1

[bkuhls]

afaics the code of this PR was committed to 24.3.1: 8017d9c

[smp79]

Yes, at last.

[teeedubb]

🎉🎉🎉

…

On 6 Aug 2024 at 08:14, smp79 ***@***.***> wrote: Yes, at last. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[ValeZAA]

afaics the code of this PR was committed to 24.3.1: 8017d9c

Can you close it then?

[xxzandy]

Alder Lake still looks like BOB using when VAAPI MCDI or MADI. Is that a hardware limitation (no advanced deinterlacing?), or why does my old Haswell can do better, and looks better, Test videos for deinterlace from Burouchs.

[smp79]

Is that a hardware limitation (no advanced deinterlacing?)

On my i5-13500 (Alder Lake-S) advanced deinterlacing works correctly, the difference with BOB is obvious. The only modern Intel HW that does not have ADI is Jasper Lake/Elkhart Lake.

[ValeZAA]

Alder Lake still looks like BOB using when VAAPI MCDI or MADI. Is that a hardware limitation (no advanced deinterlacing?), or why does my old Haswell can do better, and looks better, Test videos for deinterlace from Burouchs.

On my arrow lake Kodi has no option for MCDI/MADI. Dunno how to turn it on.

[smp79]

Kodi has no option for MCDI/MADI

Try the current nightly build of LibreELEC (you can boot the image from USB). If the options are still not there then it should be further investigated.

[ValeZAA]

Kodi has no option for MCDI/MADI

Try the current nightly build of LibreELEC (you can boot the image from USB). If the options are still not there then it should be further investigated.

Pressed live and can confirm VAAPI — Motion compensated is present and plays correctly. Nice. And it is not Bob — on my Arrow Lake Bob just crashes.

Motion adaptive has a slight opera effect as expected.

[xxzandy]

Kodi has no option for MCDI/MADI

Try the current nightly build of LibreELEC (you can boot the image from USB). If the options are still not there then it should be further investigated.

Will try in a few days. The current release version of Libreelec is the one I was referring to when I said that selecting any advanced DI method looks like BOB.

[ValeZAA]

I was wrong, Debian testing on Kodi works too. I was using MPEG2 and that does not have VAAPI Motion compensated. H.264 interlaced samples show up as VAAPI Motion compensated. OOPS. Anyway, one should now test whether the motion compensated is actually utilised.

Can be done like this: #556