Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to add vpp deinterlace weave and MotionCompensated support #556

Closed
zhuqingliang opened this issue Mar 13, 2019 · 2 comments
Closed
Assignees
Labels
Enhancement Issue: new feature or improvement In Progress PR: still under discussion VP Video Processing

Comments

@zhuqingliang
Copy link

reproduce step:
$ ffmpeg -hwaccel vaapi -vaapi_device /dev/dri/renderD128 -v debug -f rawvideo -pix_fmt yuv420p -s:v 720x480 -top 1 -i MotionTest_i_tff_720x480_10f_I420.yuv -vf 'format=nv12,hwupload,deinterlace_vaapi=mode=weave:rate=field,hwdownload,format=nv12' -pix_fmt yuv420p -vframes 20 -y dump.yuv

message:
[Parsed_deinterlace_vaapi_2 @ 0xd69e80] Deinterlacing mode 2 (Weave) is not supported.
[Parsed_deinterlace_vaapi_2 @ 0xd69e80] Failed to configure output pad on Parsed_deinterlace_vaapi_2
Error reinitializing filters!
Failed to inject frame into filter network: Invalid argument
Error while processing the decoded data for stream #0:0

$ ffmpeg -hwaccel vaapi -vaapi_device /dev/dri/renderD128 -v debug -f rawvideo -pix_fmt yuv420p -s:v 720x480 -top 1 -i /root/media/testing/assets/yuv/MotionTest_i_tff_720x480_10f_I420.yuv -vf 'format=nv12,hwupload,deinterlace_vaapi=mode=motion_compensated:rate=field,hwdownload,format=nv12' -pix_fmt yuv420p -vframes 20 -y dump.yuv

message:
[Parsed_deinterlace_vaapi_2 @ 0x1bfbf00] Deinterlacing mode 4 (MotionCompensated) is not supported.
[Parsed_deinterlace_vaapi_2 @ 0x1bfbf00] Failed to configure output pad on Parsed_deinterlace_vaapi_2
Error reinitializing filters!
Failed to inject frame into filter network: Invalid argument
Error while processing the decoded data for stream #0:0

@FurongZhang FurongZhang self-assigned this Mar 14, 2019
@FurongZhang FurongZhang added Enhancement Issue: new feature or improvement In Progress PR: still under discussion VP Video Processing labels Mar 14, 2019
@Jister Jister self-assigned this Jun 17, 2019
@Jister
Copy link
Contributor

Jister commented Jun 28, 2019

Actually, driver internally use motion compensated when app set VAProcDeinterlacingMotionAdaptive, it's a bug, so I will correct the capability from VAProcDeinterlacingMotionAdaptive to VAProcDeinterlacingMotionCompensated.
Since MCDI has better quality than MADI, so we just enable MCDI, and won't enable MADI currently. And we also won't enable VAProcDeinterlacingWeave.
Do you have a strong requirement to enable MADI/Weave? If so, could you explain in what situations will you use these modes? Thanks.

@XinfengZhang
Copy link
Contributor

already was fixed by 60cdeaa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Issue: new feature or improvement In Progress PR: still under discussion VP Video Processing
Projects
None yet
Development

No branches or pull requests

4 participants