Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][CUDA] Move interop tests #1570

Merged

Conversation

bjoernknafla
Copy link
Contributor

Move LIT test code for buffers that uses OpenCL C online compilation to
related interop test.

Apply clang-format.

Signed-off-by: Bjoern Knafla [email protected]

@bjoernknafla bjoernknafla requested a review from a team as a code owner April 22, 2020 11:38
alexbatashev
alexbatashev previously approved these changes Apr 22, 2020
Copy link
Contributor

@alexbatashev alexbatashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder, if we can use this opportunity to align test code style with the rest of project. Otherwise, LGTM.

sycl/test/basic_tests/buffer/buffer_interop.cpp Outdated Show resolved Hide resolved
sycl/test/basic_tests/buffer/buffer_interop.cpp Outdated Show resolved Hide resolved
sycl/test/basic_tests/buffer/buffer_interop.cpp Outdated Show resolved Hide resolved
Move LIT test code for buffers that uses OpenCL C online compilation to
related interop test.

Signed-off-by: Bjoern Knafla <[email protected]>
@bjoernknafla
Copy link
Contributor Author

Also applied clang-format-9 to buffer_interop.cpp.

Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for working on this.

Copy link
Contributor

@alexbatashev alexbatashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@bader bader merged commit c39327a into intel:sycl Apr 23, 2020
@bjoernknafla bjoernknafla deleted the bjoern/move-lit-buffer-interop-code branch April 23, 2020 12:53
alexbatashev pushed a commit to alexbatashev/llvm that referenced this pull request Apr 29, 2020
…versioning

* origin/sycl:
  [XPTI][Framework] Reference implementation of the Xpti framework to be used with instrumentation in SYCL (intel#1557)
  [SYCL] Initial ABI checks implementation (intel#1528)
  [SYCL] Support connection with multiple plugins (intel#1490)
  [SYCL] Add a new header file with the reduction class definition (intel#1558)
  [SYCL] Add test for SYCL kernels with accessor and spec constant (intel#1536)
  [SYCL][CUDA] Move interop tests (intel#1570)
  [Driver][SYCL] Remove COFF object format designator for Windows device compiles (intel#1574)
  [SYCL] Fix conflicting visibility attributes (intel#1571)
  [SYCL][DOC] Update the SYCL Runtime Interface document with design details (intel#680)
  [SYCL] Improve image accessors support on a host device (intel#1502)
  [SYCL] Make queue's non-USM event ownership temporary (intel#1561)
  [SYCL] Added support of rounding modes for non-host devices (intel#1463)
  [SYCL] SemaSYCL significant refactoring (intel#1517)
  [SYCL] Support 0-dim accessor in handler::copy(accessor, accessor) (intel#1551)
bb-sycl pushed a commit that referenced this pull request Sep 15, 2022
…re enabled. (#1570)

The frontend is being changed to lower the struct name to the correct LLVM name
directly, obviating the need for this check. See
#6535 for this change.

This marks the removal of the final call to the deprecated method
Type::getPointerElementType, although there remains some code that is not fully
working with opaque pointers enabled.

Original commit:
KhronosGroup/SPIRV-LLVM-Translator@e2bb479
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants