Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL][CUDA] Re-enable tests that were marked as UNSUPPORTED for the CUDA backend #1317

Merged
merged 6 commits into from
Feb 27, 2023

Conversation

jle-quel
Copy link

This PR re-enables the test marked as UNSUPPORTED for the CUDA backend.

As a result of these tests ran to update this issue: #249; Specifically, the part which mentions the tests that passed but are marked as unsupported;

I'm proposing this PR to re-enable them.

@jle-quel jle-quel requested review from Pennycook and a team as code owners October 11, 2022 08:03
Copy link

@Pennycook Pennycook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sub-group changes LGTM.

@AerialMantis AerialMantis mentioned this pull request Oct 28, 2022
@jle-quel
Copy link
Author

I wanted to check in on the status of this PR. It has passed all tests, and I believe it is ready to be merged. Is there any blocker preventing this from being reviewed or merged?

@jle-quel jle-quel requested a review from bader February 21, 2023 15:19
@bader
Copy link

bader commented Feb 21, 2023

I wanted to check in on the status of this PR. It has passed all tests, and I believe it is ready to be merged. Is there any blocker preventing this from being reviewed or merged?

Code review from @intel/llvm-reviewers-runtime team is missing.

@jle-quel
Copy link
Author

We can merge this PR now; I'm not authorized to do so, could you @bader, please?

Copy link

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@steffenlarsen steffenlarsen merged commit 281559a into intel:intel Feb 27, 2023
@jle-quel jle-quel deleted the jle-quel/re-enable-cuda-test branch February 27, 2023 10:31
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Mar 22, 2023
…_cmd-topic

[CMPLRTST-18383] valgrind command needs to be optimized by adding "--track-origins=yes"
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Mar 22, 2023
…CUDA backend (intel#1317)

This PR re-enables the test marked as UNSUPPORTED for the CUDA backend.

As a result of these tests ran to update this issue: intel#249; Specifically, the part which mentions the tests that passed but are marked as unsupported;

I'm proposing this PR to re-enable them.
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
…CUDA backend (intel/llvm-test-suite#1317)

This PR re-enables the test marked as UNSUPPORTED for the CUDA backend.

As a result of these tests ran to update this issue: intel/llvm-test-suite#249; Specifically, the part which mentions the tests that passed but are marked as unsupported;

I'm proposing this PR to re-enable them.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants