Skip to content

Commit

Permalink
[SYCL][CUDA] Re-enable tests that were marked as UNSUPPORTED for the …
Browse files Browse the repository at this point in the history
…CUDA backend (intel/llvm-test-suite#1317)

This PR re-enables the test marked as UNSUPPORTED for the CUDA backend.

As a result of these tests ran to update this issue: intel/llvm-test-suite#249; Specifically, the part which mentions the tests that passed but are marked as unsupported;

I'm proposing this PR to re-enable them.
  • Loading branch information
jle-quel authored Feb 27, 2023
1 parent ff94f4e commit 7037605
Show file tree
Hide file tree
Showing 13 changed files with 11 additions and 27 deletions.
3 changes: 0 additions & 3 deletions SYCL/Basic/built-ins.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@
// RUN: %GPU_RUN_PLACEHOLDER %t_nonvar.out %GPU_CHECK_PLACEHOLDER
// RUN: %ACC_RUN_PLACEHOLDER %t_nonvar.out %ACC_CHECK_PLACEHOLDER

// CUDA does not support printf.
// UNSUPPORTED: cuda
//
// Hits an assertion with AMD:
// XFAIL: hip_amd

Expand Down
2 changes: 0 additions & 2 deletions SYCL/Basic/handler/handler_mem_op.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
// RUN: %CPU_RUN_PLACEHOLDER %t.out
// RUN: %GPU_RUN_PLACEHOLDER %t.out

// UNSUPPORTED: cuda

//==- handler.cpp - SYCL handler explicit memory operations test -*- C++-*--==//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
Expand Down
1 change: 0 additions & 1 deletion SYCL/Basic/intel-ext-device.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
// RUN: env ONEAPI_DEVICE_SELECTOR=opencl:gpu %t.out
//
// REQUIRES: gpu
// UNSUPPORTED: cuda
// UNSUPPORTED: hip
// Temporarily disable on L0 due to fails in CI

Expand Down
3 changes: 1 addition & 2 deletions SYCL/Basic/kernel_bundle/kernel_bundle_api.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@
// RUN: %clangxx -DSYCL_DISABLE_FALLBACK_ASSERT=1 -fsycl -fsycl-device-code-split=per_kernel -fsycl-targets=%sycl_triple %s -o %t.out
// RUN: env SYCL_PI_TRACE=2 %CPU_RUN_PLACEHOLDER %t.out %CPU_CHECK_PLACEHOLDER
//
// -fsycl-device-code-split is not supported for cuda
// UNSUPPORTED: cuda || hip
// UNSUPPORTED: hip

#include <iostream>
#include <sycl/sycl.hpp>
Expand Down
2 changes: 1 addition & 1 deletion SYCL/Basic/query_emulate_subdevice.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// RUN: env CreateMultipleSubDevices=2 EnableTimestampPacket=1 \
// RUN: NEOReadDebugKeys=1 ONEAPI_DEVICE_SELECTOR="*:gpu" %t.out

// UNSUPPORTED: gpu-intel-dg1,cuda,hip
// UNSUPPORTED: gpu-intel-dg1,hip
// Temporarily disable on L0 due to fails in CI
// UNSUPPORTED: level_zero
#include "query.hpp"
3 changes: 1 addition & 2 deletions SYCL/DeprecatedFeatures/deprecated_intel_ext_device.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
// RUN: env ONEAPI_DEVICE_SELECTOR=opencl:gpu %t.out
//
// REQUIRES: gpu
// UNSUPPORTED: cuda
// UNSUPPORTED: hip
// Temporarily disable on L0 due to fails in CI
// UNSUPPORTED: level_zero
Expand Down Expand Up @@ -120,4 +119,4 @@ int main(int argc, char **argv) {
}
std::cout << "Passed!" << std::endl;
return 0;
}
}
2 changes: 1 addition & 1 deletion SYCL/DeviceLib/ITTAnnotations/atomic.cpp
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// UNSUPPORTED: cuda || hip
// UNSUPPORTED: hip

// RUN: %clangxx -fsycl -fsycl-instrument-device-code %s -o %t.out \
// RUN: -fsycl-targets=%sycl_triple
Expand Down
2 changes: 1 addition & 1 deletion SYCL/DeviceLib/ITTAnnotations/barrier.cpp
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// UNSUPPORTED: cuda || hip
// UNSUPPORTED: hip

// RUN: %clangxx -fsycl -fsycl-instrument-device-code %s -o %t.out \
// RUN: -fsycl-targets=%sycl_triple
Expand Down
4 changes: 2 additions & 2 deletions SYCL/Regression/implicit_kernel_bundle_image_filtering.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
// RUN: env SYCL_PI_TRACE=2 %GPU_RUN_PLACEHOLDER %t.out 2>&1 %GPU_CHECK_PLACEHOLDER
// RUN: env SYCL_PI_TRACE=2 %ACC_RUN_PLACEHOLDER %t.out 2>&1 %ACC_CHECK_PLACEHOLDER

// JIT compilation path is not taken on CUDA and HIP backend.
// UNSUPPORTED: cuda || hip
// JIT compilation path is not taken on HIP backend.
// UNSUPPORTED: hip

// This tests checks that implicitly created kernel_bundles (i.e. through
// setting a specialization ID from host) only builds the device image
Expand Down
2 changes: 1 addition & 1 deletion SYCL/SubGroup/reduce_spirv13_fp64.cpp
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// UNSUPPORTED: cuda || hip
// UNSUPPORTED: hip

// RUN: %clangxx -fsycl -fsycl-targets=%sycl_triple %s -o %t.out
// RUN: %CPU_RUN_PLACEHOLDER %t.out
Expand Down
2 changes: 1 addition & 1 deletion SYCL/SubGroup/scan_spirv13_fp64.cpp
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// UNSUPPORTED: cuda || hip
// UNSUPPORTED: hip

// RUN: %clangxx -fsycl -fsycl-targets=%sycl_triple %s -o %t.out
// RUN: %CPU_RUN_PLACEHOLDER %t.out
Expand Down
6 changes: 1 addition & 5 deletions SYCL/USM/dep_events.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,7 @@
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
// Prefetch operations for cuda and windows currently does not work
// cuMemPrefetchAsync returns cudaErrorInvalidDevice for this OS
// Test is temporarily disabled until this is resolved
// UNSUPPORTED: cuda && windows
//

// RUN: %clangxx -fsycl -fsycl-targets=%sycl_triple %s -o %t1.out
// RUN: %CPU_RUN_PLACEHOLDER %t1.out
// RUN: %GPU_RUN_PLACEHOLDER %t1.out
Expand Down
6 changes: 1 addition & 5 deletions SYCL/USM/prefetch.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,7 @@
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
// Prefetch operations for cuda and windows currently does not work
// cuMemPrefetchAsync returns cudaErrorInvalidDevice for this OS
// Test is temporarily disabled until this is resolved
// UNSUPPORTED: cuda && windows
//

// RUN: %clangxx -fsycl -fsycl-targets=%sycl_triple %s -o %t1.out
// RUN: %CPU_RUN_PLACEHOLDER %t1.out
// RUN: %GPU_RUN_PLACEHOLDER %t1.out
Expand Down

0 comments on commit 7037605

Please sign in to comment.