Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(model): fix image decoding issue #71

Merged
merged 4 commits into from
Dec 28, 2023
Merged

fix(model): fix image decoding issue #71

merged 4 commits into from
Dec 28, 2023

Conversation

tonywang10101
Copy link
Contributor

Because

  • parsing prompt_images field failed on text-generation related tasks

This commit

  • made prompt images optional
  • fix decoding issue

Copy link

codecov bot commented Dec 27, 2023

Codecov Report

Attention: 31 lines in your changes are missing coverage. Please review.

Comparison is base (d38447e) 34.97% compared to head (0ec6921) 34.39%.

Files Patch % Lines
instill/helpers/ray_io.py 0.00% 31 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
- Coverage   34.97%   34.39%   -0.58%     
==========================================
  Files          26       26              
  Lines        1664     1692      +28     
  Branches      414      420       +6     
==========================================
  Hits          582      582              
- Misses       1064     1092      +28     
  Partials       18       18              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tonywang10101 tonywang10101 changed the title Ins 2982 fix(model): fix image decoding issue Dec 27, 2023
Copy link
Member

@heiruwu heiruwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@heiruwu heiruwu merged commit 5c571b2 into main Dec 28, 2023
11 checks passed
@heiruwu heiruwu deleted the INS-2982 branch December 28, 2023 05:30
heiruwu pushed a commit that referenced this pull request Jan 2, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.5.0](v0.4.0...v0.5.0)
(2024-01-02)


### ⚠ BREAKING CHANGES

* **ray:** retire non-decorator deploy and update scaling config
([#67](#67))

### Features

* **model:** Update Text-Generation Task Schema to Align with OpenAI
Standards ([#69](#69))
([703789a](703789a))


### Bug Fixes

* **model:** fix image decoding issue
([#71](#71))
([5c571b2](5c571b2))
* **ray:** allow cwd as runtime env
([#66](#66))
([00c0497](00c0497))
* **ray:** avoid agressive downscale and non upscale
([#70](#70))
([f159314](f159314))


### Documentation

* **notebooks:** add async example
([49ca895](49ca895))


### Code Refactoring

* **ray:** retire non-decorator deploy and update scaling config
([#67](#67))
([89ef078](89ef078))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: 👋 Done
Development

Successfully merging this pull request may close these issues.

3 participants