Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(model): Update Text-Generation Task Schema to Align with OpenAI Standards #69

Merged
merged 2 commits into from
Dec 25, 2023

Conversation

tonywang10101
Copy link
Contributor

Because ...

  • This update is necessitated by the need to align our current text-generation-task schema more closely with OpenAI's task structure.

This commit ..

  1. Enhancement of TASK_TEXT_GENERATION: Following our discussion in INS-2982, we have introduced three new fields to the TASK_TEXT_GENERATION protocol buffer:

    • An optional system_message string.
    • An optional chat_history field, now mirroring the type used in conversation.
    • An optional image_url string, which is a base64 encoded string including batch dimension.
  2. Improved extra_param Support: To offer enhanced functionality for the extra_param, we have implemented the suggestions in INS-2954.

  3. Protobuf Structure Update: In line with the recent commit to our protobuf repository, we have migrated the model owner and org fields to a new unified owner field, ensuring consistency across our models.

Related changes

Copy link

codecov bot commented Dec 25, 2023

Codecov Report

Attention: 88 lines in your changes are missing coverage. Please review.

Comparison is base (89ef078) 36.23% compared to head (895a041) 34.97%.
Report is 3 commits behind head on main.

Files Patch % Lines
instill/helpers/ray_io.py 0.00% 71 Missing ⚠️
instill/helpers/const.py 0.00% 17 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
- Coverage   36.23%   34.97%   -1.27%     
==========================================
  Files          26       26              
  Lines        1606     1664      +58     
  Branches      405      231     -174     
==========================================
  Hits          582      582              
- Misses       1006     1064      +58     
  Partials       18       18              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@heiruwu heiruwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@heiruwu heiruwu merged commit d2e55c7 into main Dec 25, 2023
10 checks passed
@heiruwu heiruwu deleted the INS-2982 branch December 25, 2023 13:43
heiruwu pushed a commit that referenced this pull request Dec 25, 2023
…Standards (#69)

Because ... 

- This update is necessitated by the need to align our current
text-generation-task schema more closely with OpenAI's task structure.

This commit .. 

1. **Enhancement of TASK_TEXT_GENERATION**: Following our discussion in
[INS-2982](https://linear.app/instill-ai/issue/INS-2982/harmonizing-the-text-generation-tasks-protocol-buffer-with-the-openai),
we have introduced three new fields to the `TASK_TEXT_GENERATION`
protocol buffer:
   - An optional `system_message` string.
- An optional `chat_history` field, now mirroring the type used in
`conversation`.
- An optional `image_url` string, which is a base64 encoded string
including batch dimension.

2. **Improved `extra_param` Support**: To offer enhanced functionality
for the `extra_param`, we have implemented the suggestions in
[INS-2954](https://linear.app/instill-ai/issue/INS-2954/improve-param-value-filed-type).

3. **Protobuf Structure Update**: In line with the recent
[commit](instill-ai/protobufs@61c3ca8)
to our protobuf repository, we have migrated the `model owner` and `org`
fields to a new unified `owner` field, ensuring consistency across our
models.


Related changes

- [protobuf PR](instill-ai/protobufs#243)
- [model backed
PR](instill-ai/model-backend#479)
heiruwu pushed a commit that referenced this pull request Jan 2, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.5.0](v0.4.0...v0.5.0)
(2024-01-02)


### ⚠ BREAKING CHANGES

* **ray:** retire non-decorator deploy and update scaling config
([#67](#67))

### Features

* **model:** Update Text-Generation Task Schema to Align with OpenAI
Standards ([#69](#69))
([703789a](703789a))


### Bug Fixes

* **model:** fix image decoding issue
([#71](#71))
([5c571b2](5c571b2))
* **ray:** allow cwd as runtime env
([#66](#66))
([00c0497](00c0497))
* **ray:** avoid agressive downscale and non upscale
([#70](#70))
([f159314](f159314))


### Documentation

* **notebooks:** add async example
([49ca895](49ca895))


### Code Refactoring

* **ray:** retire non-decorator deploy and update scaling config
([#67](#67))
([89ef078](89ef078))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: 👋 Done
Development

Successfully merging this pull request may close these issues.

3 participants