Fix PBX:record arity for Twilio & Africa's Talking #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kakada
pushed a commit
to ilabsea/verboice
that referenced
this pull request
May 7, 2020
The `record.erl` implementation changed in 55bde09 to add a 4th parameter, but it wasn't added in `twilio_pbx.erl` See instedd#859
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
record.erlimplementation changed in 55bde09to add a 4th parameter, but it wasn't added in
twilio_pbx.erl. Andafricas_talking_pbx.erlwas based on Twilio's.See #859