Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Record transferred calls in Asterisk #859

Closed
matiasgarciaisaia opened this issue Apr 7, 2020 · 1 comment · Fixed by #860
Closed

Record transferred calls in Asterisk #859

matiasgarciaisaia opened this issue Apr 7, 2020 · 1 comment · Fixed by #860
Assignees
@matiasgarciaisaia
Labels
enhancement verified

Comments

@matiasgarciaisaia
Copy link
Member

Verboice has to offer the ability to record transferred calls for Asterisk/SIP channels.

We will enable Twilio & Africa's Talking channels in a later commit.

See #854, #856, #857
@matiasgarciaisaia matiasgarciaisaia self-assigned this Apr 7, 2020
matiasgarciaisaia added a commit that referenced this issue Apr 7, 2020
@matiasgarciaisaia
Store whether to record call in DialCommand
232ace0 
See #859
See #854, #855
matiasgarciaisaia added a commit that referenced this issue Apr 7, 2020
@matiasgarciaisaia
Support recording transferred calls in Asterisk channels
ee6089f 
See #859
matiasgarciaisaia added a commit that referenced this issue Apr 7, 2020
@matiasgarciaisaia
Extract recording_utils module in the broker
36206af 
It'll be used for recording the Dial step

See #859
matiasgarciaisaia added a commit that referenced this issue Apr 7, 2020
@matiasgarciaisaia
Support recording transferred calls in Asterisk channels
7c214a0 
Both Twilio & Africa's Talking implementations are pending

See #859
This was referenced Apr 7, 2020
Merged
Open
Open
matiasgarciaisaia added a commit that referenced this issue Apr 8, 2020
@matiasgarciaisaia
Store whether to record call in DialCommand
3ab1788 
See #859
See #854, #855
matiasgarciaisaia added a commit that referenced this issue Apr 8, 2020
@matiasgarciaisaia
Extract recording_utils module in the broker
10c5d62 
It'll be used for recording the Dial step

See #859
matiasgarciaisaia added a commit that referenced this issue Apr 8, 2020
@matiasgarciaisaia
Support recording transferred calls in Asterisk channels
e44ffb4 
Both Twilio & Africa's Talking implementations are pending

See #859
matiasgarciaisaia added a commit that referenced this issue Apr 8, 2020
@matiasgarciaisaia
Fix PBX:record arity for Twilio & Africa's Talking
5b384ab 
The `record.erl` implementation changed in 55bde09
to add a 4th parameter, but it wasn't added in `twilio_pbx.erl`

See #859
@matiasgarciaisaia matiasgarciaisaia mentioned this issue Apr 8, 2020
Merged
@mmuller
Copy link

mmuller commented Apr 9, 2020

Working properly in version d9a0609

bcardiff pushed a commit that referenced this issue Apr 13, 2020
@matiasgarciaisaia
Fix PBX:record arity for Twilio & Africa's Talking (#863)
6503297 
The `record.erl` implementation changed in 55bde09
to add a 4th parameter, but it wasn't added in `twilio_pbx.erl`

See #859
matiasgarciaisaia added a commit that referenced this issue Apr 14, 2020
@matiasgarciaisaia
Persist forwarded calls recordings when caller hangs
f208271 
If the caller hangs the call during a forwarding, we want to
keep the recording anyway.

See #860
See #859
@matiasgarciaisaia matiasgarciaisaia mentioned this issue Apr 14, 2020
Merged
bcardiff pushed a commit that referenced this issue Apr 14, 2020
@matiasgarciaisaia
Persist forwarded calls recordings when caller hangs (#871)
02acc8e 
If the caller hangs the call during a forwarding, we want to
keep the recording anyway.

See #860
See #859
kakada pushed a commit to ilabsea/verboice that referenced this issue May 7, 2020
@matiasgarciaisaia @kakada
Store whether to record call in DialCommand
ecddd62 
See instedd#859
See instedd#854, instedd#855
kakada pushed a commit to ilabsea/verboice that referenced this issue May 7, 2020
@matiasgarciaisaia @kakada
Extract recording_utils module in the broker
bc47de5 
It'll be used for recording the Dial step

See instedd#859

Conflicts:
	broker/src/commands/record.erl
kakada pushed a commit to ilabsea/verboice that referenced this issue May 7, 2020
@matiasgarciaisaia @kakada
Support recording transferred calls in Asterisk channels
09296bc 
Both Twilio & Africa's Talking implementations are pending

See instedd#859

Conflicts:
	broker/src/africas_talking/africas_talking_pbx.erl
	broker/src/asterisk/agi_session.erl
	broker/src/asterisk/asterisk_pbx.erl
	broker/src/pbx.erl
	broker/src/twilio/twilio_pbx.erl
kakada pushed a commit to ilabsea/verboice that referenced this issue May 7, 2020
@matiasgarciaisaia @kakada
Fix PBX:record arity for Twilio & Africa's Talking (instedd#863)
a76bb1d 
The `record.erl` implementation changed in 55bde09
to add a 4th parameter, but it wasn't added in `twilio_pbx.erl`

See instedd#859
kakada pushed a commit to ilabsea/verboice that referenced this issue May 7, 2020
@matiasgarciaisaia @kakada
Persist forwarded calls recordings when caller hangs (instedd#871)
4875601 
If the caller hangs the call during a forwarding, we want to
keep the recording anyway.

See instedd#860
See instedd#859
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matiasgarciaisaia matiasgarciaisaia

Labels
enhancement verified
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Record Asterisk forwarded calls instedd/verboice
2 participants
@mmuller @matiasgarciaisaia