Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #780 - Added opt-out for MDC injection of individual libraries #796

Merged
merged 2 commits into from
Jul 3, 2020

Conversation

JonasKunz
Copy link
Member

@JonasKunz JonasKunz commented Jun 29, 2020

Closes #780


This change is Reviewable

@codecov
Copy link

codecov bot commented Jun 29, 2020

Codecov Report

Merging #796 into master will decrease coverage by 0.14%.
The diff coverage is 76.67%.

@@             Coverage Diff              @@
##             master     #796      +/-   ##
============================================
- Coverage     83.00%   82.87%   -0.14%     
- Complexity     1736     1756      +20     
============================================
  Files           174      177       +3     
  Lines          5366     5452      +86     
  Branches        650      658       +8     
============================================
+ Hits           4454     4518      +64     
- Misses          675      691      +16     
- Partials        237      243       +6     
Impacted Files Coverage Δ Complexity Δ
...t/ocelot/config/model/tracing/TracingSettings.java 100.00% <ø> (ø) 0.00 <0.00> (ø)
...ion/correlation/log/adapters/Log4J1MDCAdapter.java 70.00% <0.00%> (-7.78%) 4.00 <1.00> (+1.00) ⬇️
...ion/correlation/log/adapters/Log4J2MDCAdapter.java 70.00% <0.00%> (-7.78%) 4.00 <1.00> (+1.00) ⬇️
...tion/correlation/log/adapters/Slf4jMDCAdapter.java 70.00% <0.00%> (-7.78%) 4.00 <1.00> (+1.00) ⬇️
...nstrumentation/context/ContextPropagationUtil.java 84.73% <70.37%> (-3.00%) 31.00 <3.00> (+5.00) ⬇️
...rumentation/context/propagation/DatadogFormat.java 77.14% <77.14%> (ø) 7.00 <7.00> (?)
...trumentation/context/PropagationFormatManager.java 80.00% <80.00%> (ø) 3.00 <3.00> (?)
...ocelot/config/model/tracing/PropagationFormat.java 100.00% <100.00%> (ø) 1.00 <1.00> (?)
...ore/instrumentation/correlation/log/MDCAccess.java 87.50% <100.00%> (+3.63%) 16.00 <3.00> (+3.00)
...bootstrap/instrumentation/noop/NoopMethodHook.java 33.33% <0.00%> (-66.67%) 1.00% <0.00%> (-2.00%)
... and 7 more

Copy link
Member

@mariusoe mariusoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 10 of 10 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

mariusoe
mariusoe previously approved these changes Jul 3, 2020
Copy link
Member

@mariusoe mariusoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@JonasKunz JonasKunz merged commit d658c3d into inspectIT:master Jul 3, 2020
@JonasKunz JonasKunz deleted the mdc-opt-out branch July 3, 2020 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an opt-out configuration option for each MDC integration
2 participants