Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an opt-out configuration option for each MDC integration #780

Closed
bunckelvhv opened this issue Jun 11, 2020 · 0 comments · Fixed by #796
Closed

Add an opt-out configuration option for each MDC integration #780

bunckelvhv opened this issue Jun 11, 2020 · 0 comments · Fixed by #796

Comments

@bunckelvhv
Copy link

WildFly's logging system is based on JBoss Logmanager. Additionally it ships several JBoss specific wrappers for major logging APIs

https://github.com/wildfly/wildfly-core/blob/master/pom.xml

  • Log4J 1.2 (Wrapper NOT the original API/Impl)
  • SLF4J (Wrapper hardcoded to JBoss Logmanager)
  • Jakarta Commons Logging (Wrapper hardcoded to JBoss Logmanager)
  • JBoss Logging (Wrapper, first priority in automatic detection is JBoss Logmanager)

Additionally a Logj4j2 Implementation pointing to JBoss Logmanager is available.

https://github.com/inspectIT/inspectit-ocelot/blob/master/inspectit-ocelot-core/src/main/java/rocks/inspectit/ocelot/core/instrumentation/correlation/log/MDCAccess.java
currently registers all of them at the same time.
There is no option to activate just one of the MDC Wrappers. In case of WildFly one MDC call would reach the same implementation multiple times, causing unnecessary overhead.

Please offer a option to activate just one Wrapper or set a preference order (1 JBoss Logmanager, 2 slf4j, 3 log4j2, 4 log4j12)
@bunckelvhv bunckelvhv changed the title WildFly Logging SubSystem MDC turned on/off per Thread WildFly Logging SubSystem MDC called multiple times Jun 11, 2020
@JonasKunz JonasKunz changed the title WildFly Logging SubSystem MDC called multiple times Add an opt-out configuration option for each MDC integration Jun 29, 2020
JonasKunz added a commit to JonasKunz/inspectit-ocelot that referenced this issue Jun 29, 2020
@JonasKunz
Closes inspectIT#780 - Added opt-out for MDC injection of individual …
046c09f 
…libraries
@JonasKunz JonasKunz mentioned this issue Jun 29, 2020
Merged
JonasKunz pushed a commit that referenced this issue Jul 3, 2020
Closes #780 - Added opt-out for MDC injection of individual libraries (…
d658c3d 
…#796)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #780 - Added opt-out for MDC injection of individual libraries JonasKunz/inspectit-ocelot
1 participant
@bunckelvhv