Closes #1329 - Fix parsing of Config-Yaml with unknown properties for Config-Docs

[aaronweissler]

This change is 

[mariusoe]

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @aaronweissler)

---

components/inspectit-ocelot-configdocsgenerator/src/main/java/inspectit/ocelot/configdocsgenerator/parsing/ConfigParser.java, line 61 at r1 (raw file):

            // remove any invalid keys at the top level to make the String parseable for Jackson
            yamlMap.keySet().removeIf(key -> !key.equals("inspectit"));
            configYaml = mapper.writeValueAsString(yamlMap);

It is a matter of taste, but assigning new values to method arguments is often considered "bad pratice". It is "better" to use new variables instead, e.g. cleanedConfigYaml.

---

components/inspectit-ocelot-configdocsgenerator/src/test/java/inspectit/ocelot/configdocsgenerator/parsing/ConfigParserTest.java, line 96 at r1 (raw file):

        @Test
        void withAdditionalInvalidRootKey() throws IOException {

Remove the first empty line in the method bodies :)

[aaronweissler]

Reviewable status: 2 of 4 files reviewed, 2 unresolved discussions (waiting on @mariusoe)

---

components/inspectit-ocelot-configdocsgenerator/src/main/java/inspectit/ocelot/configdocsgenerator/parsing/ConfigParser.java, line 61 at r1 (raw file):

Previously, mariusoe (Marius Oehler) wrote…

It is a matter of taste, but assigning new values to method arguments is often considered "bad pratice". It is "better" to use new variables instead, e.g. cleanedConfigYaml.

Done.

---

components/inspectit-ocelot-configdocsgenerator/src/test/java/inspectit/ocelot/configdocsgenerator/parsing/ConfigParserTest.java, line 96 at r1 (raw file):

Previously, mariusoe (Marius Oehler) wrote…

Remove the first empty line in the method bodies :)

Done.

[mariusoe]

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @aaronweissler)