Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cat-voices): setup database #1789

Merged
merged 49 commits into from
Feb 10, 2025
Merged

Conversation

damian-molinski
Copy link
Contributor

@damian-molinski damian-molinski commented Feb 5, 2025

Description

Starts work around sql db for documents storage

Related Issue(s)

Resolves #1761
Resolves #1762

Description of Changes

  • Setups clear db interface
  • Exposes only minimum necessary data
  • Testable
  • Works on web

This PR does not contain all necessary queries. Those should be implemented as required by screens / features

Reference

Specs

Related Pull Requests

Requires #1775
Requires input-output-hk/catalyst-ci#378

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@damian-molinski damian-molinski added the dart Pull requests that update Dart code label Feb 5, 2025
@damian-molinski damian-molinski self-assigned this Feb 5, 2025
Copy link
Contributor

github-actions bot commented Feb 5, 2025

Test Report | ${\color{lightgreen}Pass: 40/41}$ | ${\color{red}Fail: 1/41}$ |

Copy link
Contributor

github-actions bot commented Feb 6, 2025

Test Report | ${\color{lightgreen}Pass: 467/467}$ | ${\color{red}Fail: 0/467}$ |

Copy link
Contributor

github-actions bot commented Feb 7, 2025

Test Report | ${\color{lightgreen}Pass: 468/476}$ | ${\color{red}Fail: 8/476}$ |

catalyst_voices/Earthfile Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Feb 9, 2025

Test Report | ${\color{lightgreen}Pass: 483/489}$ | ${\color{red}Fail: 1/489}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 484/489}$ | ${\color{red}Fail: 0/489}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 41/46}$ | ${\color{red}Fail: 0/46}$ |

@damian-molinski damian-molinski marked this pull request as ready for review February 10, 2025 11:19
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 484/489}$ | ${\color{red}Fail: 0/489}$ |

Copy link
Contributor

@dtscalac dtscalac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@damian-molinski damian-molinski enabled auto-merge (squash) February 10, 2025 12:40
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 484/489}$ | ${\color{red}Fail: 0/489}$ |

@damian-molinski damian-molinski merged commit 5b5e3a9 into main Feb 10, 2025
41 checks passed
@damian-molinski damian-molinski deleted the feat/setup_database_1761 branch February 10, 2025 12:48
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 487/492}$ | ${\color{red}Fail: 0/492}$ |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dart Pull requests that update Dart code review me PR is ready for review
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Tables and Daos 🛠️ [TASK] : Setup database
2 participants