Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cat-voices): update flutter version #1775

Merged
merged 22 commits into from
Feb 5, 2025
Merged

Conversation

damian-molinski
Copy link
Contributor

@damian-molinski damian-molinski commented Feb 4, 2025

Description

Updates flutter to 3.27.3

Related Issue(s)

Unblocks drift for integration for #1761

input-output-hk/catalyst-ci#375 needs to be merged first

@damian-molinski damian-molinski added the dart Pull requests that update Dart code label Feb 4, 2025
@damian-molinski damian-molinski self-assigned this Feb 4, 2025
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Test Report | ${\color{lightgreen}Pass: 41/41}$ | ${\color{red}Fail: 0/41}$ |

Copy link
Contributor

github-actions bot commented Feb 4, 2025

Test Report | ${\color{lightgreen}Pass: 41/41}$ | ${\color{red}Fail: 0/41}$ |

Copy link
Contributor

github-actions bot commented Feb 4, 2025

Test Report | ${\color{lightgreen}Pass: 41/41}$ | ${\color{red}Fail: 0/41}$ |

Copy link
Contributor

github-actions bot commented Feb 4, 2025

Test Report | ${\color{lightgreen}Pass: 464/464}$ | ${\color{red}Fail: 0/464}$ |

Copy link
Contributor

github-actions bot commented Feb 4, 2025

Test Report | ${\color{lightgreen}Pass: 464/464}$ | ${\color{red}Fail: 0/464}$ |

Copy link
Contributor

github-actions bot commented Feb 4, 2025

Test Report | ${\color{lightgreen}Pass: 464/464}$ | ${\color{red}Fail: 0/464}$ |

Copy link
Contributor

github-actions bot commented Feb 4, 2025

Test Report | ${\color{lightgreen}Pass: 467/467}$ | ${\color{red}Fail: 0/467}$ |

@damian-molinski damian-molinski marked this pull request as ready for review February 4, 2025 13:54
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Test Report | ${\color{lightgreen}Pass: 467/467}$ | ${\color{red}Fail: 0/467}$ |

Copy link
Contributor

github-actions bot commented Feb 4, 2025

Test Report | ${\color{lightgreen}Pass: 467/467}$ | ${\color{red}Fail: 0/467}$ |

minikin
minikin previously approved these changes Feb 4, 2025
Copy link
Collaborator

@minikin minikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@minikin minikin enabled auto-merge (squash) February 4, 2025 15:43
Copy link
Contributor

@dtscalac dtscalac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before this is merged I'd like to release a new version of packages to pub.dev so that they are not affected by the flutter upgrade. I don't expects conflicts, just don't want to force anybody who is using our packages to upgrade flutter version now. Will raise a PR soon for the release.

@dtscalac
Copy link
Contributor

dtscalac commented Feb 4, 2025

Here's the PR for publishing the packages: #1781

@dtscalac dtscalac added do not merge yet PR is not ready to be merged yet and removed do not merge yet PR is not ready to be merged yet labels Feb 4, 2025
Copy link
Contributor

github-actions bot commented Feb 5, 2025

Test Report | ${\color{lightgreen}Pass: 466/467}$ | ${\color{red}Fail: 1/467}$ |

Copy link
Contributor

github-actions bot commented Feb 5, 2025

Test Report | ${\color{lightgreen}Pass: 467/467}$ | ${\color{red}Fail: 0/467}$ |

Copy link
Contributor

github-actions bot commented Feb 5, 2025

Test Report | ${\color{lightgreen}Pass: 467/467}$ | ${\color{red}Fail: 0/467}$ |

Copy link
Contributor

@dtscalac dtscalac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@minikin minikin merged commit 6cc4285 into main Feb 5, 2025
43 of 44 checks passed
@minikin minikin deleted the chore/update_flutter_version branch February 5, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dart Pull requests that update Dart code
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants