Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: ScrumlrLogo gradient colors #4312

Merged
merged 38 commits into from
Jul 16, 2024
Merged

refactor: ScrumlrLogo gradient colors #4312

merged 38 commits into from
Jul 16, 2024

Conversation

Schwehn42
Copy link
Member

Description

Fixes/Refactors the gradient colors used in the ScrumlrLogo component.

Before

Previously, the ScrumlrLogo component would use classes als props to generate the gradient, however, the colors themselves were hardcoded. This didn't work with the new accent color refactor.

After

Now, the gradients are generated dynamically using the proper accent color classes (#4304) and based on the current theme color (#4310). The gradients now looks correct again.

Changelog

  • ScrumlrLogo: Generate gradient stops based on array consisting of colors.
  • The color array changes depending on the active theme (useAutoTheme)
  • removes accentColorClass prop, and change all files who used ScrumlrLogo to reflect the change.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • The light- and dark-theme are both supported and tested
  • The design was implemented and is responsive for all devices and screen sizes
  • The application was tested in the most commonly used browsers (e.g. Chrome, Firefox, Safari)

@Schwehn42 Schwehn42 added the Review Needed This pull request is ready for review label Jul 15, 2024
@Schwehn42 Schwehn42 self-assigned this Jul 15, 2024
@Schwehn42 Schwehn42 mentioned this pull request Jul 15, 2024
5 tasks

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

# Conflicts:
#	src/components/ScrumlrLogo/ScrumlrLogo.scss
#	src/components/Votes/VoteButtons/RemoveVoteButton.scss
Copy link

The deployment to the dev cluster was successful. You can find the deployment here: https://4312.development.scrumlr.fra.ics.inovex.io
This deployment is only for testing purposes and will be deleted after 1 week.
To redeploy rerun the workflow.
DO NOT STORE IMPORTANT DATA ON THIS DEPLOYMENT

Deployed Images
  • ghcr.io/inovex/scrumlr.io/scrumlr-frontend:sha-da59ce0

  • ghcr.io/inovex/scrumlr.io/scrumlr-server:sha-da59ce0

Copy link

octomind-dev bot commented Jul 16, 2024

🐙 Octomind

Test Report: 12/14 successful.

description status details
About Section Visibility Test Passed ✅ click
change avatar Passed ✅ click
check Privacy Policy Passed ✅ click
check terms & conditions Passed ✅ click
close cookie banner - front page Passed ✅ click
close cookie banner - sign-in Passed ✅ click
create and delete board columns Failed ❌ click
create_and_delete_notes_and_actions_v2 Failed ❌ click
create lean coffee board Passed ✅ click
edit_notes_and_actions_v5 Passed ✅ click
get started Passed ✅ click
share_session Passed ✅ click
sign-in Passed ✅ click
test all ways to open the setup flow Passed ✅ click

commit sha: da59ce0

Copy link
Contributor

@BenedictHomuth BenedictHomuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Schwehn42 Schwehn42 removed the Review Needed This pull request is ready for review label Jul 16, 2024
@Schwehn42 Schwehn42 added this pull request to the merge queue Jul 16, 2024
Merged via the queue into main with commit ad91da3 Jul 16, 2024
10 checks passed
@Schwehn42 Schwehn42 deleted the js/dynamic-scrumlr-logo branch July 16, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants