-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: ScrumlrLogo gradient colors #4312
Conversation
This reverts commit 9906c32.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
# Conflicts: # src/components/ScrumlrLogo/ScrumlrLogo.scss # src/components/Votes/VoteButtons/RemoveVoteButton.scss
The deployment to the dev cluster was successful. You can find the deployment here: https://4312.development.scrumlr.fra.ics.inovex.io Deployed Images
|
🐙 OctomindTest Report: 12/14 successful.
commit sha: da59ce0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
Fixes/Refactors the gradient colors used in the
ScrumlrLogo
component.Before
Previously, the
ScrumlrLogo
component would use classes als props to generate the gradient, however, the colors themselves were hardcoded. This didn't work with the new accent color refactor.After
Now, the gradients are generated dynamically using the proper accent color classes (#4304) and based on the current theme color (#4310). The gradients now looks correct again.
Changelog
ScrumlrLogo
: Generate gradient stops based on array consisting of colors.useAutoTheme
)accentColorClass
prop, and change all files who usedScrumlrLogo
to reflect the change.Checklist