-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: accent colors #4304
refactor: accent colors #4304
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
The deployment to the dev cluster was successful. You can find the deployment here: https://4304.development.scrumlr.fra.ics.inovex.io Deployed Images
|
🐙 OctomindTest Report: 13/14 successful.
commit sha: 74ea870 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
This PR refactors the accent colors. It's basically the second part to #4283, which changed all the color definitions.
Before
Previously, the two primary colors (light/dark) for each color was used to define the accent colors. For instance, using the classname
accent-color__backlog-blue
would yield the accent color--accent-color: $blue--500
(andaccent-color--dark: $blue--400
respectively). On top of that, further CSS variables like--accent-color-desaturated-hover-dark
were defined. The definitions were completely arbitrary and were used at own discretion instead of the actual design colors.Furthermore, some designs use accent colors beyond 500 and 400, e.g. the new primary/secondary buttons. This actually motivated me to refactor this.
After
Now, not only the primary colors are used as accent colors, but all colors from the new schema are available. (e.g.
--accent-color--300
)The primary colors are still easily accessible using shortcuts (
--accent-color--light
,--accent-color-dark
).Also, all shades are available as rgb, which means alpha channel can be applied.
"Excess" variables like the above mentioned desatured.. have been replaced with the new ones.
Changelog
set-accent-variables
andgenerate-accent-classes
backlog-blue
)--accent-color--100
to--accent-color-800
--accent-color--light
and--accent-color--dark
Checklist
(Optional) Visual Changes