Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: accent colors #4304

Merged
merged 25 commits into from
Jul 16, 2024
Merged

refactor: accent colors #4304

merged 25 commits into from
Jul 16, 2024

Conversation

Schwehn42
Copy link
Member

Description

This PR refactors the accent colors. It's basically the second part to #4283, which changed all the color definitions.

Before

Previously, the two primary colors (light/dark) for each color was used to define the accent colors. For instance, using the classname accent-color__backlog-blue would yield the accent color --accent-color: $blue--500 (and accent-color--dark: $blue--400 respectively). On top of that, further CSS variables like --accent-color-desaturated-hover-dark were defined. The definitions were completely arbitrary and were used at own discretion instead of the actual design colors.

Furthermore, some designs use accent colors beyond 500 and 400, e.g. the new primary/secondary buttons. This actually motivated me to refactor this.

After

Now, not only the primary colors are used as accent colors, but all colors from the new schema are available. (e.g. --accent-color--300)
The primary colors are still easily accessible using shortcuts (--accent-color--light, --accent-color-dark).
Also, all shades are available as rgb, which means alpha channel can be applied.
"Excess" variables like the above mentioned desatured.. have been replaced with the new ones.

Changelog

  • move colors to separate file
  • add colors to map
  • new mixins set-accent-variables and generate-accent-classes
    • generate accent variables for each color class (like backlog-blue)
    • shades from --accent-color--100 to --accent-color-800
    • shortcuts --accent-color--light and --accent-color--dark
    • split rgb version for each shade
    • remove excess accent variables
  • use new accent colors in every file that requires them
  • some manual adjustements (e.g. concerning note reactions) to fix some colors

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • The light- and dark-theme are both supported and tested
  • The design was implemented and is responsive for all devices and screen sizes
  • The application was tested in the most commonly used browsers (e.g. Chrome, Firefox, Safari)

(Optional) Visual Changes

@Schwehn42 Schwehn42 added the Review Needed This pull request is ready for review label Jul 12, 2024
@Schwehn42 Schwehn42 added this to the Update UI Library milestone Jul 12, 2024
@Schwehn42 Schwehn42 self-assigned this Jul 12, 2024

This comment has been minimized.

@Schwehn42 Schwehn42 added Blocked This pull request or issue is currently blocked by another issue and removed Blocked This pull request or issue is currently blocked by another issue labels Jul 15, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link

The deployment to the dev cluster was successful. You can find the deployment here: https://4304.development.scrumlr.fra.ics.inovex.io
This deployment is only for testing purposes and will be deleted after 1 week.
To redeploy rerun the workflow.
DO NOT STORE IMPORTANT DATA ON THIS DEPLOYMENT

Deployed Images
  • ghcr.io/inovex/scrumlr.io/scrumlr-frontend:sha-74ea870

  • ghcr.io/inovex/scrumlr.io/scrumlr-server:sha-74ea870

Copy link

octomind-dev bot commented Jul 16, 2024

🐙 Octomind

Test Report: 13/14 successful.

description status details
About Section Visibility Test Passed ✅ click
change avatar Passed ✅ click
check Privacy Policy Passed ✅ click
check terms & conditions Passed ✅ click
close cookie banner - front page Passed ✅ click
close cookie banner - sign-in Passed ✅ click
create and delete board columns Failed ❌ click
create_and_delete_notes_and_actions_v2 Passed ✅ click
create lean coffee board Passed ✅ click
edit_notes_and_actions_v5 Passed ✅ click
get started Passed ✅ click
share_session Passed ✅ click
sign-in Passed ✅ click
test all ways to open the setup flow Passed ✅ click

commit sha: 74ea870

Copy link
Contributor

@BenedictHomuth BenedictHomuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Schwehn42 Schwehn42 removed the Review Needed This pull request is ready for review label Jul 16, 2024
@Schwehn42 Schwehn42 added this pull request to the merge queue Jul 16, 2024
Merged via the queue into main with commit f725f28 Jul 16, 2024
10 checks passed
@Schwehn42 Schwehn42 deleted the js/color-refactor-addendum branch July 16, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants