-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: hidden columns not showing after promotion to moderator #4234
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Therefore we should check and decide, if we want to publish the AccountType information or not. If not, I can also just annotate the AccountType in the DTO with "omitempty".
AccountType
is required for #4229, does this have an impact on it?
If I see it correctly, the information of |
The deployment to the dev cluster was successful. You can find the deployment here: https://4234.development.scrumlr.fra.ics.inovex.io Deployed Images
|
🐙 OctomindTest Report: 13/14 successful.
commit sha: a2c65b1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Co-authored-by: Benedict Homuth <[email protected]>
Description
Whenever someone gets promoted to moderator, he/she should be able to see the hidden columns. This is now possible since we sync columns (
ColumnsUpdated
) on aParticipantUpdated
event.Before, this call was not present resulting in a situation where the newly named moderator needed to refresh the page to finally see the hidden columns.
Since #4179 has broadened the scope of a BoardSession DTO – specifically the AccountType – I needed to extend our DB calls, since when I parse the event in the EventFilter, it errors, since AccountType can not be an empty string (at least for now).
Therefore we should check and decide, if we want to publish the AccountType information or not. If not, I can also just annotate the AccountType in the DTO with "omitempty".
Changelog
Checklist
(Optional) Visual Changes