Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: middleware allow actions from authenticated accounts only #4179

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

mateo-ivc
Copy link
Contributor

Description

Implemented middleware that allows actions from authenticated accounts only

Changelog

api/context.go
Middleware that checks if the user's account-type is Anonymous
dto/users.go
added account-type field to the dto struct

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • The light- and dark-theme are both supported and tested
  • The design was implemented and is responsive for all devices and screen sizes
  • The application was tested in the most commonly used browsers (e.g. Chrome, Firefox, Safari)

(Optional) Visual Changes

@mateo-ivc mateo-ivc added the Review Needed This pull request is ready for review label May 29, 2024
Copy link

octomind-dev bot commented May 29, 2024

🐙 Octomind

Test Report: 0/14 successful.

description status details
About Section Visibility Test Failed ❌ click
change avatar Failed ❌ click
check Privacy Policy Failed ❌ click
check terms & conditions Failed ❌ click
close cookie banner - front page Failed ❌ click
close cookie banner - sign-in Failed ❌ click
create and delete board columns Failed ❌ click
create_and_delete_notes_and_actions_v2 Failed ❌ click
create lean coffee board Failed ❌ click
edit_notes_and_actions_v5 Failed ❌ click
get started Failed ❌ click
share_session Failed ❌ click
sign-in Failed ❌ click
test all ways to open the setup flow Failed ❌ click

commit sha: 6a5b76a

@mateo-ivc mateo-ivc self-assigned this Jun 3, 2024
Copy link
Member

@Schwehn42 Schwehn42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lookin' good

might consider adding a test file for all the context functions at some point

@Schwehn42 Schwehn42 removed the Review Needed This pull request is ready for review label Jun 3, 2024
Copy link

github-actions bot commented Jun 3, 2024

The deployment to the dev cluster was successful. You can find the deployment here: https://4179.development.scrumlr.fra.ics.inovex.io
This deployment is only for testing purposes and will be deleted after 1 week.
To redeploy rerun the workflow.
DO NOT STORE IMPORTANT DATA ON THIS DEPLOYMENT

Deployed Images
  • ghcr.io/inovex/scrumlr.io/scrumlr-frontend:sha-80383d3

  • ghcr.io/inovex/scrumlr.io/scrumlr-server:sha-80383d3

Copy link

octomind-dev bot commented Jun 3, 2024

🐙 Octomind

Test Report: 14/14 successful.

description status details
About Section Visibility Test Passed ✅ click
change avatar Passed ✅ click
check Privacy Policy Passed ✅ click
check terms & conditions Passed ✅ click
close cookie banner - front page Passed ✅ click
close cookie banner - sign-in Passed ✅ click
create and delete board columns Passed ✅ click
create_and_delete_notes_and_actions_v2 Passed ✅ click
create lean coffee board Passed ✅ click
edit_notes_and_actions_v5 Passed ✅ click
get started Passed ✅ click
share_session Passed ✅ click
sign-in Passed ✅ click
test all ways to open the setup flow Passed ✅ click

commit sha: 80383d3

@mateo-ivc mateo-ivc added this pull request to the merge queue Jun 3, 2024
Merged via the queue into main with commit b2d729c Jun 3, 2024
6 checks passed
@mateo-ivc mateo-ivc deleted the mi/middleware-authenticated-only branch June 3, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants