Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: can't select captions in shorts with hide auto captions - ON. #484

Closed
3 tasks done
kyan5221 opened this issue Mar 14, 2023 · 14 comments
Closed
3 tasks done

bug: can't select captions in shorts with hide auto captions - ON. #484

kyan5221 opened this issue Mar 14, 2023 · 14 comments
Labels
Bug report Something isn't working

Comments

@kyan5221
Copy link

Type

Error at runtime

Application

v18.09.39 + v2.164.32 patches

Bug description

can't select and play captions when I enable hide auti captions.

Steps to reproduce

  1. enable hide auto captions
  2. play shorts video which has captions
  3. try to select or change captions.

Relevant log output

no logs

Screenshots or videos

20230315_004113

Solution

No response

Additional context

No response

Device Environment

android 13
samsung oneui 5.1

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@kyan5221 kyan5221 added the Bug report Something isn't working label Mar 14, 2023
@inotia00
Copy link
Owner

fixed in revanced-patches-v2.165.1

@kyan5221
Copy link
Author

kyan5221 commented Mar 15, 2023

fixed in revanced-patches-v2.165.1

caption issue in shorts player has not been fixed yet in v2.165.1.

all languages are checked as V and I can't change language if I set hide auto caption as enabled.
shorts player displays 'subtitle turned off message' only and not showing subtitle.

there is no error in normal youtube player, it happens only in shorts.

I did clean installation and set only 3 items(two hide shorts disabled, hide auto cation enabled).

KakaoTalk_20230315_121826558
KakaoTalk_20230315_121826558_01
KakaoTalk_20230315_121826558_02
KakaoTalk_20230315_121826558_03
KakaoTalk_20230315_121826558_04

@inotia00
Copy link
Owner

inotia00 commented Mar 15, 2023

ahh i misunderstood

Hide auto captions is a setting in Player settings

So.. it does not hide or disable any component in Shorts Player.

So it's normal that it doesn't work

Patch to turn off captions in Shorts Player has not been implemented

@inotia00 inotia00 reopened this Mar 15, 2023
@inotia00
Copy link
Owner

However.. since this is a valid bug, I will reopen the issue.

@inotia00
Copy link
Owner

fixed in revanced-patches-v2.166.8

@kyan5221
Copy link
Author

fixed in revanced-patches-v2.166.8

is 'hide-auto-caption' only for normal video? not for shorts?

my issue is that caption in shorts are displayed automatically even I enabled 'hide-auto-caption'.
is it normal in RVX?

@inotia00
Copy link
Owner

iirc, I changed it to only apply to normal videos, as I can't fix the issue in Shorts.

If you are willing to provide additional context, please provide the following information:

  1. Please provide the URL of the video with forced auto captions in Shorts.
  2. Please check if this issue is reproduced in the official ReVanced.

@inotia00
Copy link
Owner

inotia00 commented Jan 16, 2024

Updated:
I found Shorts with forced auto captions, and I tested it on ReVanced and RVX, respectively.

Video url:
https://youtube.com/shorts/BB5HDvgPb3E

When Disable forced auto captions is turned on, the results of Revanced and RVX are as follows.

result

Stock YouTube: Forced auto captions is applied
Revanced: Disable forced auto captions works, but still has issue.
RVX: Disable forced auto captions works, issue has been resolved.

Probably, if you still have this issue, simply apply the patch again.

In revanced-patches-v2.209.1, Disable forced auto captions will also be applied in Shorts.

@kyan5221
Copy link
Author

kyan5221 commented Jan 16, 2024

Updated: I found Shorts with forced auto captions, and I tested it on ReVanced and RVX, respectively.

Video url: https://youtube.com/shorts/BB5HDvgPb3E

When Disable forced auto captions is turned on, the results of Revanced and RVX are as follows.

result

Stock YouTube: Forced auto captions is applied Revanced: Disable forced auto captions works, but still has issue. RVX: Disable forced auto captions works, issue has been resolved.

Probably, if you still have this issue, simply apply the patch again.

In revanced-patches-v2.209.1, Disable forced auto captions will also be applied in Shorts.

in most case, captions are turned off automatically in shorts. but sometimes (scroll up shorts videos) it doesn't block captions and displays captions.
so I have to select 'turn off captions' manually in shorts.
Screenshot_20240116_190340_YouTube
Screenshot_20240116_190353_Settings
Screenshot_20240116_190406_YouTube

@inotia00
Copy link
Owner

Please let me know the version of revanced-patches

@kyan5221
Copy link
Author

kyan5221 commented Jan 16, 2024

Please let me know the version of revanced-patches

v2.210.1

Screenshot_20240116_192054_YouTube

@inotia00
Copy link
Owner

If so, this is a bug.

It is impossible to fix it because it cannot be reproduced on my side, but I will reopen the previously opened issue for other users who visit with the same issue.

@kyan5221
Copy link
Author

kyan5221 commented Jan 16, 2024

If so, this is a bug.

It is impossible to fix it because it cannot be reproduced on my side, but I will reopen the previously opened issue for other users who visit with the same issue.

I found how to reproduce it.

  1. enable 'Disable forced auto captions ' in RVX settings.
  2. play one video and click CC overlay button to turn on caption and watch it with caption.
  3. watch other videos.
  4. select shorts in nav bar and play shorts videos which has 'forced auto captions'.
  5. shorts player will display caption in this case.

is it a bug or normal?

@inotia00
Copy link
Owner

If so, this is not a bug

Disable force auto captions setting prevents captions from being applied to videos where auto captions are forced

As a representative example, auto captions are forced when the following Shorts are opened on an stock YouTube or in a web browser

https://youtube.com/shorts/BB5HDvgPb3E

Disable force auto captions setting makes prevent this

It is not a feature that disables remembering captions that the user previously changed

If you use official ReVanced, you can disable remembering captions in Shorts, but this will make it impossible for users to enable captions in Shorts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants