Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: hide comment component keeps failing #1291

Closed
5 tasks done
ILoveOpenSourceApplications opened this issue Jul 31, 2023 · 1 comment
Closed
5 tasks done

bug: hide comment component keeps failing #1291

ILoveOpenSourceApplications opened this issue Jul 31, 2023 · 1 comment
Labels
Bug report Something isn't working

Comments

@ILoveOpenSourceApplications
Copy link

Type

Error while patching

Tools used

ReVanced Manager

Application

YouTube v18.29.38

Bug description

When patching YouTube via RVX Manager, this specific patch fails everytime.

Steps to reproduce

  1. Try patching with `hide comment component' patch included.
  2. See that it's failing.

Relevant log output

Nil

Screenshots or videos

Screenshot_20230801-001312~2

Solution

No response

Additional context

No response

Device Environment

No response

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
  • I have written the title and contents in English.
  • This issue does not reproduce on unpatched YouTube or YT Music.
@ILoveOpenSourceApplications ILoveOpenSourceApplications added the Bug report Something isn't working label Jul 31, 2023
inotia00 added a commit to inotia00/revanced-patches that referenced this issue Jul 31, 2023
@inotia00
fix(youtube): some dependence is missing inotia00/ReVanced_Extended#1291
4d2fd8f
@inotia00
Copy link
Owner

inotia00 commented Aug 3, 2023

fixed in revanced-patches-v2.186.12

@inotia00 inotia00 closed this as completed Aug 3, 2023
ayushTNM pushed a commit to ayushTNM/revanced-patches that referenced this issue Sep 20, 2023
@semantic-release-bot
chore(release): 2.185.0 [skip ci]
0aa5fb4 
# [2.185.0](v2.184.31...v2.185.0) (2023-09-20)

### Bug Fixes

* compile error ([0a27088](0a27088))
* **music/custom-branding-music-name:** compile error in RVX Manager ([e0e6dad](e0e6dad))
* **music/exclusive audio playback:** not compatible with latest version ([a1fa3a2](a1fa3a2))
* **music/hide-upgrade-button:** not compatible with latest version ([4eec203](4eec203))
* **music/remember-video-quality:** not compatible with latest version ([b1adb5f](b1adb5f))
* **music/settings:** blank screen appears when text input dialog is shown ([a14d53f](a14d53f))
* **music:** compile issues due to wrong decoding ([ba53f73](ba53f73))
* **overlay-button:** match vertical fullscreen icon with others ([inotia00#15](https://github.com/ayushTNM/revanced-patches/issues/15)) inotia00/ReVanced_Extended#1221 ([5c4b9b0](5c4b9b0))
* **overlay-buttons:** fullscreen icon does not match ([851dbcf](851dbcf))
* patch error ([25d311b](25d311b))
* **reddit/open-links-externally:** exceptions occur in some manufacturers ROM ([dea655e](dea655e))
* **reddit/reddit-settings:** now when the patch is applied through the RVX Manager, the settings are added normally ([1528885](1528885))
* **youtube/custom-branding-youtube-name:** takes too long to apply the patch in the RVX Manager ([441a9ec](441a9ec))
* **youtube/default-video-quality:** rollback commit ([94a36ed](94a36ed))
* **youtube/enable-new-splash-animation:** remove android version restriction ([b4057ef](b4057ef))
* **youtube/hide-layout-components:** custom filters are separated by commas instead of line-by-line ([3ac0a6b](3ac0a6b))
* **youtube/hide-layout-components:** expandable chip under videos not hidden in related videos ([a54954a](a54954a))
* **youtube/hide-shorts-components:** sometimes shorts shelves are not hidden from the home feed ([39645be](39645be))
* **youtube/hide-shorts-components:** wrong case notation ([fa76fe9](fa76fe9))
* **youtube/hide-suggested-actions:** not hidden normally in some situations ([3d6307f](3d6307f))
* **youtube/hide-suggested-video-overlay:** overlay is not hidden in some case ([ebdc38a](ebdc38a))
* **youtube/old-quality-layout:** does not work on tablet devices ([16c34b7](16c34b7))
* **youtube/overlay-button:** overlay button not hidden when scrubbing seekbar ([7164f72](7164f72))
* **youtube/overlay-buttons:** `Disable playlist autoplay` loops video in minimized and PiP mode ([59edd59](59edd59))
* **youtube/overlay-buttons:** remove unnecessary dependencies ([a58a05a](a58a05a))
* **youtube/settings:** wrong alphabetical alignment ([b1e8a1c](b1e8a1c))
* **youtube/sponsorblock:** fix some segments skipping slightly too late ([8a748e9](8a748e9))
* **youtube/spoof-app-version:** change target version `17.30.34` > `17.08.35` ([e26d7be](e26d7be))
* **youtube/swipe-controls:** When `Press-to-swipe` is disabled, `Press-to-swipe haptic feedback` should also be disabled inotia00/ReVanced_Extended#811 ([95cfc3d](95cfc3d))
* **youtube:** reinforce weak fingerprints ([1320590](1320590))
* **youtube:** remove dummy code ([f65d9a8](f65d9a8))
* **youtube:** some dependence is missing inotia00/ReVanced_Extended#1291 ([4d2fd8f](4d2fd8f))
* **youtube:** some fingerprints are located in the wrong path ([2549347](2549347))

### Features

* add microg patches ([709b2eb](709b2eb))
* generate an exception when an invalid value is entered ([63b0227](63b0227))
* **microg:** add microg-mmt-icon and microg-materialyou patches ([inotia00#12](https://github.com/ayushTNM/revanced-patches/issues/12)) ([84fd6a8](84fd6a8))
* **microg:** minor improvement ([09d5313](09d5313))
* **microg:** temporary suspension of support for all patches inotia00/ReVanced_Extended#1207 ([03b9875](03b9875))
* **music/amoled:** patch now applies the amoled theme to the comment input box as well ([f0dfbd2](f0dfbd2))
* **music/enable-custom-filter:** separate filters by line instead of commas ([2afe861](2afe861))
* **music/enable-new-layout:** change default value ([30b4ae7](30b4ae7))
* **music/enable-new-layout:** forcibly disable when the switch is off ([939a403](939a403))
* **music/enable-sleep-timer:** forcibly disable when the switch is off ([00a3694](00a3694))
* **music/hide-get-premium:** patch now also hides the premium membership label in settings ([0473a62](0473a62))
* **music/microg-support:** renamed patch name ([58dd674](58dd674))
* **music/music-translations:** update translation ([74657e8](74657e8))
* **music/music-translations:** update translation ([0f33289](0f33289))
* **music/music-translations:** update translation ([167b6d1](167b6d1))
* **music/music-translations:** update translation ([af39d0c](af39d0c))
* **music/music-translations:** update translation ([3066e1c](3066e1c))
* **music/settings:** change some default value ([2c16e7e](2c16e7e))
* **music/translations:** update translation ([ac1d310](ac1d310))
* **music/translations:** update translation ([f51a23f](f51a23f))
* **music/translations:** update translation ([ec92314](ec92314))
* **music:** add `enable playback speed` patch ([63628d6](63628d6))
* **music:** add `enable-old-style-library-shelf` patch ([6abfa67](6abfa67))
* **music:** add `hide-button-container-labels` patch ([2eff3d2](2eff3d2))
* **music:** add `hide-channel-guidelines` patch ([98c8214](98c8214))
* **music:** add `hide-emoji-picker` patch ([45fcce5](45fcce5))
* **music:** add `hide-flyout-panel` patch ([bc8338a](bc8338a))
* **music:** add `hide-radio-button` patch ([3c306eb](3c306eb))
* **music:** add `remember-playback-speed` patch ([679e11e](679e11e))
* **music:** add `return-youtube-dislike` patch ([f97d6de](f97d6de))
* **music:** add compatibility version constraints (ryd does not support older versions) ([c5a68bf](c5a68bf))
* **music:** change patch description ([b9f2fca](b9f2fca))
* **music:** remove `enable-dismiss-queue` patch (applied to all users) ([3663d07](3663d07))
* **reddit/hide-ads:** add missing dependency ([d5e8fad](d5e8fad))
* **reddit/hide-ads:** implementing with settings ([263a3c5](263a3c5))
* **reddit/hide-discover-community-button:** change patch name `hide-discover-button` > `hide-discover-community-button` ([360da14](360da14))
* **reddit/hide-navigation-buttons:** supports the latest version ([6b826bd](6b826bd))
* **reddit:** add `hide-place-button` patch ([b3a5631](b3a5631))
* **reddit:** remove `decoding-patch` that are no longer used ([ed6a45a](ed6a45a))
* remove `decoding-patch` that are no longer used ([c00af81](c00af81))
* **youtube/custom-seekbar-color:** apply custom seekbar color to shorts ([ddbf533](ddbf533))
* **youtube/enable-new-thumbnail-preview:** forcibly disable when the switch is off ([639e40d](639e40d))
* **youtube/enable-old-quality-layout:** do not use low level filter anymore ([599c30a](599c30a))
* **youtube/enable-old-quality-layout:** match with the official Revanced ([ee5fc11](ee5fc11))
* **youtube/hide-button-container:** now it support versions other than YouTube v18.20.39 ReVanced/revanced-patches#2723 ([1fbb5c4](1fbb5c4))
* **youtube/hide-comment-component:** `hide preview comment` hides the dots of live comments ([c80d0e7](c80d0e7))
* **youtube/hide-layout-components:** add `Hide chips shelf` settings inotia00/ReVanced_Extended#1180 ([5b872de](5b872de))
* **youtube/hide-layout-components:** change the default value of `Hide expandable chip under video` ([d1f2fc6](d1f2fc6))
* **youtube/hide-player-flyout-panel:** add `Hide lock screen menu` settings ([0e83d2c](0e83d2c))
* **youtube/hide-suggested-video-overlay:** no longer dependent on `overlay-buttons` patches ([837a54c](837a54c))
* **youtube/language-switch:** add a new type of string ([fc668c3](fc668c3))
* **youtube/navbar-index-hook:** no longer depend on low-level filters ([2d4ffd6](2d4ffd6))
* **youtube/spoof-app-version:** add 18.09.39 to version list ([86647ab](86647ab))
* **youtube/spoof-player-parameters:** match with official revanced patches ([2ade6e4](2ade6e4))
* **youtube/spoof-player-parameters:** no longer automatically spoofed ([e3b3c09](e3b3c09))
* **youtube/spoof-player-parameters:** no longer automatically spoofed ([a250124](a250124))
* **youtube/spoof-player-parameters:** set default value to `on` in non-root environments only ([8c90204](8c90204))
* **youtube/spoof-player-parameters:** switch default spoofing type ([d80ad01](d80ad01))
* **youtube/translations:** update translation ([adcc265](adcc265))
* **youtube/translations:** update translation ([7442a45](7442a45))
* **youtube/translations:** update translation ([15fbe7d](15fbe7d))
* **youtube/translations:** update translation ([7742b5f](7742b5f))
* **youtube/translations:** update translation ([805adc8](805adc8))
* **youtube/translations:** update translation ([b6a2c2b](b6a2c2b))
* **youtube/translations:** update translation ([e03b36f](e03b36f))
* **youtube/translations:** update translation ([cadc272](cadc272))
* **youtube:** add `hide-latest-videos-button` patch ([ab663b8](ab663b8))
* **youtube:** add `hide-suggested-video-overlay` patch ([b03dee0](b03dee0))
* **youtube:** add support version `v18.19.36` & `v18.31.40` ([47b2ed2](47b2ed2))
* **youtube:** add support version `v18.27.35` ([db82839](db82839))
* **youtube:** add support version `v18.27.36` ([09d06fc](09d06fc))
* **youtube:** add support version `v18.29.38` ([0b09058](0b09058))
* **youtube:** add support version `v18.30.37` ([d8a10fe](d8a10fe))
* **youtube:** minor improvement ([eaced95](eaced95))
* **youtube:** preparation for discontinuation ([22db45a](22db45a))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug report Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@inotia00 @ILoveOpenSourceApplications