-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect build mode from metadata on deploy #193
Conversation
src/lib/contract.ts
Outdated
if (!check.result && check.missingTypes.includes(".contract")) { | ||
throw new FileError( | ||
`Cannot read .contract bundle, path not found: ${check.missingPaths.join(', ')}` | ||
); | ||
} | ||
|
||
const contractFilePath = path.resolve(this.artifactsPath, `${this.moduleName}.json`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if I'm not mistaken, in case when only .json
file is missing, we will fail at the 61st line; maybe let's just check only check.result
(?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, it should be enough @prxgr4mm3r
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I optimized the Contract
class by initializing the build mode directly within the constructor since contract's build lifecycle remains consistent across various commands such as contract deploy
, contract call
, and contract test
.
just to ensure - on this branch there is no way to have a verifiable build using swanky-cli, right? |
I just synced this branch with the Swanky verifiable build command and added a |
No description provided.